-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nexverse Bid Adapter : initial relese #12297
Nexverse Bid Adapter : initial relese #12297
Conversation
…, and added device and connection type detection
Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):
|
updated function build request |
Can you please add docs to our docs repo for this pr -> https://github.com/prebid/prebid.github.io/pulls Also, if you pull in master tests should be fixed |
Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):
|
Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):
|
docs PR prebid/prebid.github.io#5640 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bidder duplicates a lot of logic in the request object unnecessarily. Please simplify dramatically.
* created utils for all common code * reused prebid inbuild functions * created nexverse.html to text nexverse adaptor * changed test specs based on main js
* created utils for all common code * reused prebid inbuild functions * created nexverse.html to text nexverse adaptor * changed test specs based on main js
* Fixed issues of 1.Category 2.Domain 3.Attributes * Added Nexverse Demo html for testing with sample bid * Handled Height and width issue
* fixed bidFloor issue
Tread carefully! This PR adds 1 linter warning (possibly disabled through directives):
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information