Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prebid Core: targeting keys issue when enableSendAllBids and alwaysIncludeDeals is true #12518

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Prebid Core: targeting keys issue when enableSendAllBids and alwaysIncludeDeals is true #12518

merged 2 commits into from
Dec 6, 2024

Conversation

pm-priyanka-deshmane
Copy link
Contributor

@pm-priyanka-deshmane pm-priyanka-deshmane commented Nov 28, 2024 •
edited
Loading

Type of change

  • Bugfix

Description of change

When both the enableSendAllBids and alwaysIncludeDeals flags are set to true, targeting keys for bids without deals have not been passed to the ad server since version 9.16.0.
We suspect that this issue may have been caused by the changes introduced in PR #12273.
Specifically, before checking the value of the alwaysIncludeDeals flag and dealId, we are not checking the value of the enableSendAllBids flag.

Other information

When below config is set, if there is a bid without deal, targeting keys for that bid were being skipped in adserver call.

        enableSendAllBids: true,
        targetingControls: {
          alwaysIncludeDeals: true
        }

@pm-priyanka-deshmane pm-priyanka-deshmane changed the title targeting keys issue when enableSendAllBids and alwaysIncludeDeals is true Prebid Core: targeting keys issue when enableSendAllBids and alwaysIncludeDeals is true Nov 28, 2024
@pm-priyanka-deshmane
Copy link
Contributor Author

@dgirardi @patmmccann @jlquaccia Can you review this?

@ChrisHuie ChrisHuie requested a review from dgirardi December 3, 2024 16:10
dgirardi
dgirardi approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@dgirardi dgirardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting and fixing this!

jlquaccia
jlquaccia approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@jlquaccia jlquaccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pm-priyanka-deshmane
Copy link
Contributor Author

@jlquaccia Can you merge this PR ?

@ChrisHuie ChrisHuie merged commit 0ca1fee into prebid:master Dec 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgirardi dgirardi dgirardi approved these changes

@jlquaccia jlquaccia jlquaccia approved these changes

Assignees

@dgirardi dgirardi

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pm-priyanka-deshmane @jlquaccia @dgirardi @patmmccann @ChrisHuie