fix for not syncing bidders. #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbemiller
approved these changes
Sep 19, 2017
|
Probably worth having a test to prevent regressions |
protonate
suggested changes
Sep 19, 2017
modules/prebidServerBidAdapter.js
Outdated
| @@ -212,7 +212,9 @@ function PrebidServer() { | |||
| */ | |||
| baseAdapter.queueSync = function({bidderCodes}) { | |||
| let syncedList = StorageManager.get(pbjsSyncsKey) || []; | |||
| if (_cookiesQueued || syncedList.length === bidderCodes.length) { | |||
| // filter synced bidders - https://github.com/prebid/Prebid.js/issues/1582 | |||
| syncList = bidderCodes.filter(bidder => !syncList.includes(bidder)); | |||
There was a problem hiding this comment.
typo in variable name, should be syncedList, or syncList, but consistent
dbemiller
approved these changes
Sep 19, 2017
matthewlane
approved these changes
Sep 19, 2017
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Sep 21, 2017
* tag '0.29.0' of https://github.com/prebid/Prebid.js: (29 commits) Prebid 0.29.0 Release Fix for not syncing bidders. (prebid#1598) fix amp example pages (prebid#1597) closes prebid#1298 (prebid#1583) Fixed the broken tests. (prebid#1602) Rubicon Bidder Factory (prebid#1587) Trustx adapter (prebid#1488) Add nurl to markup (prebid#1601) Pass bidRequest to createBid (prebid#1600) Add Kumma adapter (prebid#1512) Serverbid alias (prebid#1560) Add user sync to process for approving adapter PRs (prebid#1457) fix travis build (prebid#1595) Rubicon project improvement/user sync (prebid#1549) Adding Orbitsoft adapter (prebid#1378) Fix renderer test for new validation rule (prebid#1592) Allow SET_TARGETING to be used in AnalyticsAdapter (prebid#1577) Add support for video stream context (prebid#1483) Invalidate bid if matching bid request not found (prebid#1575) allow adapters to set default adserverTargeting for specific bid (prebid#1568) ...
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
Oct 13, 2017
….29.0 to aolgithub-master * commit 'd7a1d285acbf95fad7562f1c0077ea99df9e5976': (45 commits) Added changelog entry. Add support for secure bid requests for one mobile get endpoint. Fixed adding undefined value for request without data Fixed wrong userSyncs type for image tags Updated unit tests for AOL userSyncOn. Added support for dropping pixels after bid response. Improved code formatting, fixed typos. Added userSync feature for aol adapter. Added test cases for contentType and headers. Fixes unit tests for AOL adapter. Added cpm adjustment warning. Added initial support for unit tests. Added drop pixels support. Added bid response handler. Converted AOL bid adapter to Prebid 1.0. Added changelog entry. Added new aol partners ids. Prebid 0.29.0 Release Fix for not syncing bidders. (prebid#1598) fix amp example pages (prebid#1597) closes prebid#1298 (prebid#1583) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for #1582
I'll update this PR shortly with another fix