Trion Interactive 1.0 adapter update #1712
Conversation
…an up/consistency of tests.
| interpretResponse: function (trionResponseObj, request) { | ||
| var bid = {}; | ||
| var bidResponses = []; | ||
| var bidRequest = request.bidRequest; |
There was a problem hiding this comment.
Where is this coming from? I think you're doing something similar to what I did in the rubicon adapter to get the original bidRequest, but I attached it to the request; I don't see you doing the same in this code.
There was a problem hiding this comment.
Hey @snapwich, the bidrequest is included in the build request function on line 25 of the adapter. I'm sending it up with the bid request object for each bid. The request is coming through on all the tests on my end. Let me know if there is something I'm missing.
modules/trionBidAdapter.js
Outdated
| if (!userTag.int_t) { | ||
| userTag.int_t = window.TR_INT_T || -1; | ||
| bid.requestId = bidRequest.bidId; | ||
| bid.bidderCode = bidRequest.bidder; |
There was a problem hiding this comment.
This line needs to be dropped. Sorry for the confusion.
|
@grohm33 One thing to fix and then this can merge. Sorry for the delay! |
… the test that requires it
|
@mkendall07 the bidder code was removed. Thanks! |
* Adding files associated with the trion adapter update to the newest prebid version(1.0). * Updating pull request with safer checks for user sync and general clean up/consistency of tests. * removing a call to bidder code for pull request review. also removing the test that requires it
…rebid version(1.0).
Type of change
Description of change
Adding updated adapter for the 1.0 release
mgroh@trioninteractive.com
Other information
We have a test ad set up to return bids from pubId : '30222' and sectionId : '5' and will only do so on mobile user agent.