Update sharethrough bid adapter #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewlane
reviewed
Oct 31, 2017
There was a problem hiding this comment.
Thanks for the updated adapter. Please also add your .md file in this PR: http://prebid.org/dev-docs/bidder-adapter-1.html#planning-your-adapter
|
Sorry about that, I updated the PR with the .md file. Thanks for the review |
matthewlane
reviewed
Nov 1, 2017
modules/sharethroughBidAdapter.js
Outdated
|
|
||
| return [{ | ||
| requestId: req.data.bidId, | ||
| bidderCode: BIDDER_CODE, |
There was a problem hiding this comment.
bidderCode will be set automatically by bidderFactory now, this line can be dropped
modules/sharethroughBidAdapter.js
Outdated
| }; | ||
| }) | ||
| }, | ||
| interpretResponse: (resp, req) => { |
There was a problem hiding this comment.
#1748 changed the first argument of interpretResponse to:
{
body: responseBody,
headers: {
get: function(header) { /* returns a header from the HTTP response */ }
}
}so adding something like
resp = resp.body;just below this line, or however you'd prefer to grab the body, and updating corresponding tests if needed should get this back to working properly
|
Awesome, good to know. Ready for review |
chriscpan
force-pushed
the
cp/str-adapter-update
branch
2 times, most recently
from
580181a to
381161d
Compare
matthewlane
approved these changes
Nov 3, 2017
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Update sharethrough bid adapter * add md for sharethroughBidAdpapter * remove bidderCode and parse response * remove linting errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Sharetrough bid adapter update for Prebid 1.0