Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated adxcg adapter for prebid 1.0 #1741

Merged
merged 6 commits into from
Oct 26, 2017
Merged

updated adxcg adapter for prebid 1.0 #1741

merged 6 commits into from
Oct 26, 2017

Conversation

adxcgcom
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

adxcg bid adapter update for Prebid 1.0

dbemiller
dbemiller suggested changes Oct 24, 2017
View reviewed changes
Copy link
Contributor

@dbemiller dbemiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great to me.

Needs just two small changes, and then I can approve it.

modules/adxcgBidAdapter.js Outdated
let bid = {};

bid.requestId = serverResponseOneItem.bidId;
bid.bidderCode = spec.code;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't set the bidderCode here... It breaks adapter aliasing.

Our docs were probably bad at the time you wrote this, but they've since been updated.

modules/adxcgBidAdapter.js Outdated
*/
interpretResponse: function (serverResponse, bidRequests) {
// utils.logMessage(`interpretResponse serverResponse: ${JSON.stringify(response)}`); // remove for PRODUCTION
// utils.logMessage(`interpretResponse bidRequest ${JSON.stringify(bidRequests)}`); // remove for PRODUCTION
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the dead code, please.

@dbemiller dbemiller self-assigned this Oct 24, 2017
@dbemiller dbemiller assigned matthewlane and unassigned dbemiller Oct 24, 2017
@dbemiller dbemiller requested a review from matthewlane October 24, 2017 15:05
@dbemiller
Copy link
Contributor

akh... sorry, but one more change, because #1742 got merged before we could get this in.

The first argument to interpretResponse now looks like this:

{
  body: responseBody,
  headers: {
    get: function(header) { /* returns a header from the HTTP response */ }
  }
}

You'll have to pull master and update the spec so that it looks digs into that object as well now.

@matthewlane matthewlane merged commit d5f1cd1 into prebid:master Oct 26, 2017
Millerrok pushed a commit to Vertamedia/Prebid.js that referenced this pull request Oct 31, 2017
Merge branch 'master' of https://github.com/prebid/Prebid.js
e45235f 
* 'master' of https://github.com/prebid/Prebid.js: (22 commits)
  Update GetIntent adapter to 1.0 version (prebid#1721)
  Add `usePaymentRule` param to AN bidders (prebid#1778)
  New hooks API (replaces monkey-patching for currency) (prebid#1683)
  Change prebidServer to call client user syncs if they exist (prebid#1734)
  Fix Centro adapter to allow requests of the same units (prebid#1746)
  add vastUrl + media type for video bids Prebid Server (prebid#1739)
  Update adxcg adapter for prebid 1.0 (prebid#1741)
  Update yieldmoBid adapter request url (prebid#1771)
  Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753)
  Fidelity Media Adapter update. Prebid v1.0 (prebid#1719)
  Kargo Adapter for Prebid 1.0 (prebid#1729)
  updated for prebid 1.0 api (prebid#1722)
  Add AdOcean adapter (prebid#1735)
  Update Conversant adapter to Prebid 1.0 (prebid#1711)
  Fix test-coverage bug (prebid#1765)
  Migrating TrustX adapter to 1.0 (prebid#1709)
  Update Improve Digital adapter for Prebid 1.0 (prebid#1728)
  Fixed the argument type on getUserSyncs. (prebid#1767)
  nanointeractive bid adapter (prebid#1627)
  Validating bid response params (prebid#1738)
  ...
mattpr pushed a commit to mattpr/Prebid.js that referenced this pull request Oct 31, 2017
@adxcgcom @mattpr
Update adxcg adapter for prebid 1.0 (prebid#1741)
0ff0b32 
* updated adxcg adapter for prebid 1.0

* update for prebid 1.0 with dead code and bidder removed

* updates to spec file for prebid 1.0 - removal of biddercode check

* updated adxcg bidadapter for prebid-1.0 with response headers
outoftime pushed a commit to Genius/Prebid.js that referenced this pull request Nov 13, 2017
Merge tag '0.32.0' of https://github.com/prebid/Prebid.js into prebuilt
d52f0c7 
* tag '0.32.0' of https://github.com/prebid/Prebid.js: (44 commits)
  Prebid 0.32.0 Release
  Commenting out tests that are failing in IE10 (prebid#1710)
  Update dfp.buildVideoUrl to accept adserver url (prebid#1663)
  Update rubicon adapter with new properties and 1.0 changes (prebid#1776)
  Added adUnitCode for compatibility (prebid#1781)
  Remove 'supported' from analytics adapter info (prebid#1780)
  Add TTL parameter to bid (prebid#1784)
  Update GetIntent adapter to 1.0 version (prebid#1721)
  Add `usePaymentRule` param to AN bidders (prebid#1778)
  New hooks API (replaces monkey-patching for currency) (prebid#1683)
  Change prebidServer to call client user syncs if they exist (prebid#1734)
  Fix Centro adapter to allow requests of the same units (prebid#1746)
  add vastUrl + media type for video bids Prebid Server (prebid#1739)
  Update adxcg adapter for prebid 1.0 (prebid#1741)
  Update yieldmoBid adapter request url (prebid#1771)
  Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753)
  Fidelity Media Adapter update. Prebid v1.0 (prebid#1719)
  Kargo Adapter for Prebid 1.0 (prebid#1729)
  updated for prebid 1.0 api (prebid#1722)
  Add AdOcean adapter (prebid#1735)
  ...
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@adxcgcom @dluxemburg
Update adxcg adapter for prebid 1.0 (prebid#1741)
adee1c7 
* updated adxcg adapter for prebid 1.0

* update for prebid 1.0 with dead code and bidder removed

* updates to spec file for prebid 1.0 - removal of biddercode check

* updated adxcg bidadapter for prebid-1.0 with response headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbemiller dbemiller dbemiller approved these changes

@matthewlane matthewlane matthewlane approved these changes

Assignees

@matthewlane matthewlane

Labels
needs update Prebid 1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adxcgcom @dbemiller @matthewlane @mjacobsonny