Underdog Media 1.0 Compliance #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacobkmiller
changed the title
jaiminpanchal27
requested changes
Nov 7, 2017
There was a problem hiding this comment.
@Jacobkmiller Thanks for updating adapter.
Left some minor comments.
modules/underdogmediaBidAdapter.js
Outdated
|
|
||
| function _makeNotification(bid, mid, bidParam) { | ||
| makeNotification: function (bid, mid, bidParam) { |
There was a problem hiding this comment.
makeNotification and getUrlVars function can remain private in adapter. No need to added them to spec
| return { | ||
| method: 'GET', | ||
| url: `${window.location.protocol}//udmserve.net/udm/img.fetch`, | ||
| data: `tid=1;dt=10;sid=${siteId};sizes=${sizes.join(',')}`, |
There was a problem hiding this comment.
More params can be added to request object here. So you can add bidParams to bidRequest and access that in interpretResponse method.
By doing this you can remove bidParams line 15.
| siteId: '12143' | ||
| }, | ||
| requestId: '10b327aa396609', | ||
| placementCode: '/123456/header-bid-tag-1' |
There was a problem hiding this comment.
In 1.0 we have renamed placementCode to adUnitCode. Please rename
|
Thanks @jaiminpanchal27 for the review. I have updated the PR with your changes. |
jaiminpanchal27
approved these changes
Nov 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Update of Underdog Media adapter for 1.0 Compliance