Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

33Across Adapter (legacy): Fixing bugs found during beta test #2346

Merged
merged 1 commit into from
Apr 16, 2018
Merged

33Across Adapter (legacy): Fixing bugs found during beta test #2346

merged 1 commit into from
Apr 16, 2018

Conversation

curlyblueeagle
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • Infer creativeId from crid which is the correct source
  • Send cookie withCredentials in order to userSync properly

Be sure to test the integration with your adserver using the Hello World sample page.

@curlyblueeagle curlyblueeagle changed the title Fixing bugs found during beta test 33Across: Fixing bugs found during beta test Apr 4, 2018
@curlyblueeagle curlyblueeagle changed the title 33Across: Fixing bugs found during beta test 33Across Adapter: Fixing bugs found during beta test Apr 4, 2018
@curlyblueeagle curlyblueeagle changed the title 33Across Adapter: Fixing bugs found during beta test 33Across Adapter (legacy): Fixing bugs found during beta test Apr 4, 2018
@mkendall07 mkendall07 self-requested a review April 4, 2018 21:14
@mkendall07 mkendall07 self-assigned this Apr 4, 2018
@curlyblueeagle
Copy link
Contributor Author

Hello! We really need this in the next release of 0.34.x to continue our beta tests which are on hold at present.

mkendall07
mkendall07 approved these changes Apr 16, 2018
View reviewed changes
Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkendall07 mkendall07 merged commit 06a3eb2 into prebid:legacy Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkendall07 mkendall07 mkendall07 approved these changes

Assignees

@mkendall07 mkendall07

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curlyblueeagle @mkendall07