Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cleanup and proper stubbing for legacy analytics #2388

Merged

Conversation

snapwich
Copy link
Collaborator

Type of change

  • Bugfix

Description of change

This is an effort to apply a lot of the analytics test fixes I made in master to the legacy branch. Most of the fixes are around making sure the analytics test suites properly stub and clean up events in their test suites. A failure to do so is what I think accounts for many of the errors as seen in #2382

@stale
Copy link

stale bot commented Apr 26, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@jaiminpanchal27 jaiminpanchal27 merged commit 909e1c8 into prebid:legacy Apr 26, 2018
@robertrmartinez robertrmartinez deleted the legacy-analytics-fixes branch July 5, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants