Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(adyoulikeAdapter): adapt adapter to gdpr #2518

Merged
merged 2 commits into from
May 21, 2018

Conversation

j343my
Copy link
Contributor

@j343my j343my commented May 10, 2018

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

GDPR Support

DOC PR

prebid/prebid.github.io#754

@j343my j343my force-pushed the adyoulikeAdapter-gdpr branch from 5a3877b to c10cbc8 Compare May 10, 2018 18:15
@harpere harpere self-assigned this May 11, 2018
if (bidderRequest && bidderRequest.gdprConsent) {
payload.gdprConsent = {
consentString: bidderRequest.gdprConsent.consentString,
consentRequired: bidderRequest.gdprConsent.gdprApplies
Copy link
Collaborator

@harpere harpere May 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that gdprApplies may sometimes be undefined

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh thanks! Fixed

Copy link
Collaborator

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you are ok with gdprApplies possibly being undefined

@harpere
Copy link
Collaborator

harpere commented May 15, 2018

@j343my can you confirm the functionality I asked about? 1.11 will be released in a few hours.

@j343my
Copy link
Contributor Author

j343my commented May 17, 2018

@harpere fixed

thanks ;)

@harpere harpere merged commit af28478 into prebid:master May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants