Add renderer on vuble adapter #2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, do you know if you'll be able to review this PR soon ? Thanks, |
idettman
approved these changes
May 23, 2018
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* mod var name bids vuble adaptor * mod vuble adaptor vid request var name * Add: renderer for vuble outstream ads * mod vuble progress outstream player is bar * add vuble unit test for adUnitCode * no volume vuble adapter renderer
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* mod var name bids vuble adaptor * mod vuble adaptor vid request var name * Add: renderer for vuble outstream ads * mod vuble progress outstream player is bar * add vuble unit test for adUnitCode * no volume vuble adapter renderer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add handle of AppNexus renderer for outstream video ads on vuble adapter + some code refactorisation.