execute bidsBackHandler when auction is canceled by consent module #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
added
the
needs 2nd review
mkendall07
reviewed
May 17, 2018
modules/consentManagement.js
Outdated
| @@ -163,6 +164,7 @@ export function requestBidsHook(config, fn) { | |||
| nextFn = fn; | |||
| haveExited = false; | |||
| let adUnits = config.adUnits || $$PREBID_GLOBAL$$.adUnits; | |||
| bidsBackHandler = config.bidsBackHandler; | |||
There was a problem hiding this comment.
is this safe? What about concurrent auctions with distinct bidBackHandler functions?
There was a problem hiding this comment.
Oh i see this is fine. I assumed it was the global config import { config } from 'src/config';
You probably should rename this param so it's not confused with the global.
There was a problem hiding this comment.
Thanks for the feedback, I renamed the variable.
mkendall07
approved these changes
May 18, 2018
jaiminpanchal27
approved these changes
May 22, 2018
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
…rebid#2555) * add support to execute bidsBackHandler when auction is canceled by consent module * rename config variable
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
…rebid#2555) * add support to execute bidsBackHandler when auction is canceled by consent module * rename config variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fixes issue #2551
Currently when the prebid auction is canceled by the consentManagement module, the
bidsBackHandlerincluded in therequestBidsfunction is not executed.This fix will now execute the
bidsBackHandlerfunction when cancellation happens.