-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppNexus AST Debug Auction #3025
Conversation
This pull request introduces 1 alert when merging 32c6c80 into d7f3f90 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
This pull request introduces 1 alert when merging 32c6c80 into fa78634 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we want to introduce bid adapters to being able to read query params. That's a lot of stuff for us to keep track of per bidder. I wonder if we could do a cookie for this instead?
Hey @mkendall07 I based this approach off of audienceNetwork's The query string parameters in this case are meant more to override what would be set via a parameter on the bid request--so it would still be part of the documentation with the URL parameter as the alternative. (maybe this is the approach that should be taken to ensure tests/etc work as expected?) I could move to a cookie approach, but that makes this a bit more complex for users to access though imo (the process of setting the cookie might also need to be set multiple times if the publisher has multiple domains) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I plan to revise based on #3067 |
@aneuway2 let's chat before you update. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Closing this PR in favor of #3152 |
Type of change
Description of change
The following feature enhancement adds in the ability for a publisher or developer to request an AppNexus AST debug auction in the response back from AppNexus alongside any bids.
This feature is disabled by default and can be enabled by adding a
debug
object in parallel to the bids requested (which is the preferred way of running a debug auction):The following also may be set with a combination of the following URL parameters (and sample values) that must be used in conjunction with
pbjs_debug=true
as a URL parameter:ast_debug=true
ast_dongle=QWERTY
ast_debug_member=958
ast_debug_timeout=1200
(e.g http://example.com/?pbjs_debug=true&ast_debug=true&ast_dongle=QWERTY&ast_debug_member=882&ast_debug_timeout=1200)
When either of the above is enabled, a debug auction will be shown in the Prebid console log statements along with relevant details about the auction that took place. e.g: