Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adxcgBidAdapter - added pubcid #3824

Merged
merged 7 commits into from
May 30, 2019
Merged

adxcgBidAdapter - added pubcid #3824

merged 7 commits into from
May 30, 2019

Conversation

adxcgcom
Copy link
Contributor

Type of change

  • [x ] Feature

Description of change

Added userid module support

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code update looks good, however can you add a unit test to check the added pubcid?

@adxcgcom
Copy link
Contributor Author

code updated with unit-tests and local gulp test runs OK.
circleci tests that fail are not related to our code and are at the moment latching between different code - probabably circleci - browserstack internal issue.

just to restart CircleCI
@idettman idettman merged commit 582ecdf into prebid:master May 30, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* adxcgBidAdapter - added pubcid

* mini fix

* Update adxcgBidAdapter

Added minimal change to restart CI process

* added passing tdid, updated pubcid

* unit test for userid support - pubcid, tdid

* Update adxcgBidAdapter.js

just to restart CircleCI

* Update adxcgBidAdapter.js 

just to restart CircleCI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants