Rhythmone Adapter - Remove usersync, devicetype, and bad banners #3927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, rubicon's got failing tests? That failure is not related to this PR. |
sumit116
reviewed
Jun 24, 2019
modules/rhythmoneBidAdapter.js
Outdated
| @@ -92,15 +36,21 @@ function RhythmOneBidAdapter() { | |||
| impObj.secure = win.location.protocol === 'https:' ? 1 : 0; | |||
|
|
|||
| if (utils.deepAccess(BRs[i], 'mediaTypes.banner') || utils.deepAccess(BRs[i], 'mediaType') === 'banner') { | |||
| impObj.banner = frameBanner(BRs[i]); | |||
| let banner = frameBanner(BRs[i]); | |||
| if (banner !== false) { | |||
There was a problem hiding this comment.
Can we simplify it by if(banner)
|
OK, the comment's been addressed. We've configured our system to consistently return ads. @sumit116 could you try again? The ci error above is unrelated to this PR. |
sumit116
approved these changes
Jul 15, 2019
sumit116
added
the
needs 2nd review
jsnellbaker
approved these changes
Jul 19, 2019
leonardlabat
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Jul 30, 2019
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
bhaines@rhythmone.com