From 63dfc1b538ad57bca0afd35299718581797884be Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Thu, 26 Sep 2019 15:41:09 +0530 Subject: [PATCH 01/40] Add files via upload --- modules/advertlyBidAdapter.js | 129 ++++++++++++++++++++++++++++++++++ modules/advertlyBidAdapter.md | 50 +++++++++++++ 2 files changed, 179 insertions(+) create mode 100644 modules/advertlyBidAdapter.js create mode 100644 modules/advertlyBidAdapter.md diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js new file mode 100644 index 00000000000..07a569fa17f --- /dev/null +++ b/modules/advertlyBidAdapter.js @@ -0,0 +1,129 @@ +import { registerBidder } from '../src/adapters/bidderFactory'; +import { config } from '../src/config'; +import * as utils from '../src/utils'; +import {BANNER, VIDEO} from '../src/mediaTypes'; +import { ajax } from '../src/ajax'; +import {Renderer} from '../src/Renderer'; + +const SUPPORTED_AD_TYPES = [BANNER, VIDEO]; +const BIDDER_CODE = 'advertly'; +const DOMAIN = ''; +const RENDERER_URL = '//acdn.adnxs.com/video/outstream/ANOutstreamVideo.js'; + +function isBidRequestValid(bid) { + return (typeof bid.params !== 'undefined' && parseInt(utils.getValue(bid.params, 'publisherId')) > 0); +} + +function buildRequests(validBidRequests) { + return { + method: 'POST', + url: DOMAIN + 'www/admin/plugins/Prebid/getAd.php', + options: { + withCredentials: false, + crossOrigin: true + }, + data: validBidRequests, + }; +} + +function interpretResponse(serverResponse, request) { + const response = serverResponse.body; + const bidResponses = []; + var bidRequestResponses = []; + + utils._each(response, function(bidAd) { + bidAd.adResponse = { + content: bidAd.vastXml, + height: bidAd.height, + width: bidAd.width + }; + bidAd.ttl = config.getConfig('_bidderTimeout') + bidAd.renderer = bidAd.context === 'outstream' ? createRenderer(bidAd, { + id: bidAd.adUnitCode, + url: RENDERER_URL + }, bidAd.adUnitCode) : undefined; + bidResponses.push(bidAd); + }); + + bidRequestResponses.push({ + function: 'saveResponses', + request: request, + response: bidResponses + }); + sendResponseToServer(bidRequestResponses); + return bidResponses; +} + +function outstreamRender(bidAd) { + bidAd.renderer.push(() => { + window.ANOutstreamVideo.renderAd({ + sizes: [bidAd.width, bidAd.height], + width: bidAd.width, + height: bidAd.height, + targetId: bidAd.adUnitCode, + adResponse: bidAd.adResponse, + rendererOptions: { + showVolume: false, + allowFullscreen: false + } + }); + }); +} + +function createRenderer(bidAd, rendererParams, adUnitCode) { + const renderer = Renderer.install({ + id: rendererParams.id, + url: rendererParams.url, + loaded: false, + config: {'player_height': bidAd.height, 'player_width': bidAd.width}, + adUnitCode + }); + try { + renderer.setRender(outstreamRender); + } catch (err) { + utils.logWarn('Prebid Error calling setRender on renderer', err); + } + return renderer; +} + +function onBidWon(bid) { + let wonBids = []; + wonBids.push(bid); + wonBids[0].function = 'onBidWon'; + sendResponseToServer(wonBids); +} + +function onTimeout(details) { + details.unshift({ 'function': 'onTimeout' }); + sendResponseToServer(details); +} + +function sendResponseToServer(data) { + ajax(DOMAIN + 'www/admin/plugins/Prebid/tracking/track.php', null, JSON.stringify(data), { + withCredentials: false, + method: 'POST', + crossOrigin: true + }); +} + +function getUserSyncs(syncOptions) { + if (syncOptions.iframeEnabled) { + return [{ + type: 'iframe', + url: DOMAIN + 'www/admin/plugins/Prebid/userSync.php' + }]; + } +} + +export const spec = { + code: BIDDER_CODE, + supportedMediaTypes: SUPPORTED_AD_TYPES, + isBidRequestValid, + buildRequests, + interpretResponse, + getUserSyncs, + onBidWon, + onTimeout +}; + +registerBidder(spec); diff --git a/modules/advertlyBidAdapter.md b/modules/advertlyBidAdapter.md new file mode 100644 index 00000000000..fc3573bd28c --- /dev/null +++ b/modules/advertlyBidAdapter.md @@ -0,0 +1,50 @@ +# Overview + +``` +Module Name: Advertly Bid Adapter +Module Type: Bidder Adapter +Maintainer : support@djaxtech.com +``` + +# Description + +Connects to Advertly Ad Server for bids. + +advertly bid adapter supports Banner and Video. + +# Test Parameters +``` + var adUnits = [ + //bannner object + { + code: 'banner-ad-slot', + mediaTypes: { + banner: { + sizes: [[300, 250], [300,600]], + } + }, + bids: [{ + bidder: 'advertly', + params: { + publisherId: 2 + } + }] + + }, + //video object + { + code: 'video-ad-slot', + mediaTypes: { + video: { + context: 'instream', + playerSize: [640, 480], + }, + }, + bids: [{ + bidder: "advertly", + params: { + publisherId: 2 + } + }] + }]; +``` From dec2a7f030cec818fd563dc4c53733127e7754d6 Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Thu, 26 Sep 2019 15:43:16 +0530 Subject: [PATCH 02/40] Add files via upload --- test/spec/advertlyBidAdapter_spec.js | 159 +++++++++++++++++++++++++++ 1 file changed, 159 insertions(+) create mode 100644 test/spec/advertlyBidAdapter_spec.js diff --git a/test/spec/advertlyBidAdapter_spec.js b/test/spec/advertlyBidAdapter_spec.js new file mode 100644 index 00000000000..c02a99b3905 --- /dev/null +++ b/test/spec/advertlyBidAdapter_spec.js @@ -0,0 +1,159 @@ +import { expect } from 'chai'; +import { spec } from 'modules/advertlyBidAdapter'; + +const ENDPOINT = ''; + +describe('The Advertly bidding adapter', function () { + describe('isBidRequestValid', function () { + it('should return false when given an invalid bid', function () { + const bid = { + bidder: 'advertly', + }; + const isValid = spec.isBidRequestValid(bid); + expect(isValid).to.equal(false); + }); + + it('should return true when given a publisherId in bid', function () { + const bid = { + bidder: 'advertly', + params: { + publisherId: 2 + }, + }; + const isValid = spec.isBidRequestValid(bid); + expect(isValid).to.equal(true); + }); + }); + + describe('buildRequests', function () { + const bidRequests = [{ + 'bidder': 'advertly', + 'params': { + 'publisherId': 2 + }, + 'adUnitCode': 'adunit-code', + 'sizes': [ + [300, 250], + [300, 600] + ] + }]; + + const request = spec.buildRequests(bidRequests); + + it('sends bid request to our endpoint via POST', function () { + expect(request.method).to.equal('POST'); + }); + + it('check endpoint url', function () { + expect(request.url).to.equal(ENDPOINT) + }); + + it('sets the proper banner object', function () { + expect(bidRequests[0].params.publisherId).to.equal(2); + }) + }); + const response = { + body: [ + { + 'requestId': '2ee937f15015c6', + 'cpm': '0.2000', + 'width': 300, + 'height': 600, + 'creativeId': '4', + 'currency': 'USD', + 'netRevenue': true, + 'ad': 'ads.html', + 'mediaType': 'banner' + }, + { + 'requestId': '3e1af92622bdc', + 'cpm': '0.2000', + 'creativeId': '4', + 'context': 'outstream', + 'currency': 'USD', + 'netRevenue': true, + 'vastUrl': 'tezt.xml', + 'width': 640, + 'height': 480, + 'mediaType': 'video' + }] + }; + + const request = [ + { + 'bidder': 'advertly', + 'params': { + 'publisherId': 2 + }, + 'mediaTypes': { + 'banner': { + 'sizes': [ + [300, 600] + ] + } + }, + 'bidId': '2ee937f15015c6', + 'src': 'client', + }, + { + 'bidder': 'advertly', + 'params': { + 'publisherId': 2 + }, + 'mediaTypes': { + 'video': { + 'context': 'outstream', + 'playerSize': [ + [640, 480] + ] + } + }, + 'bidId': '3e1af92622bdc', + 'src': 'client', + } + ]; + + describe('interpretResponse', function () { + it('return empty array when no ad found', function () { + const response = {}; + const request = { bidRequests: [] }; + const bids = spec.interpretResponse(response, request); + expect(bids).to.have.lengthOf(0); + }); + + it('check response for banner and video', function () { + const bids = spec.interpretResponse(response, request); + expect(bids).to.have.lengthOf(2); + expect(bids[0].requestId).to.equal('2ee937f15015c6'); + expect(bids[0].cpm).to.equal('0.2000'); + expect(bids[1].cpm).to.equal('0.2000'); + expect(bids[0].width).to.equal(300); + expect(bids[0].height).to.equal(600); + expect(bids[1].vastUrl).to.not.equal(''); + expect(bids[0].ad).to.not.equal(''); + expect(bids[1].adResponse).to.not.equal(''); + expect(bids[1].renderer).not.to.be.an('undefined'); + }); + }); + + describe('On winning bid', function () { + const bids = spec.interpretResponse(response, request); + spec.onBidWon(bids); + }); + + describe('On bid Time out', function () { + const bids = spec.interpretResponse(response, request); + spec.onTimeout(bids); + }); + + describe('user sync', function () { + it('to check the user sync iframe', function () { + let syncs = spec.getUserSyncs({ + iframeEnabled: true + }); + expect(syncs).to.not.be.an('undefined'); + expect(syncs).to.have.lengthOf(1); + expect(syncs[0].type).to.equal('iframe'); + }); + }); +}); From 15564fc4884e92e3e136dfc4d7b1f6ef2013c752 Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Thu, 26 Sep 2019 16:00:07 +0530 Subject: [PATCH 03/40] Delete advertlyBidAdapter.js --- modules/advertlyBidAdapter.js | 129 ---------------------------------- 1 file changed, 129 deletions(-) delete mode 100644 modules/advertlyBidAdapter.js diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js deleted file mode 100644 index 07a569fa17f..00000000000 --- a/modules/advertlyBidAdapter.js +++ /dev/null @@ -1,129 +0,0 @@ -import { registerBidder } from '../src/adapters/bidderFactory'; -import { config } from '../src/config'; -import * as utils from '../src/utils'; -import {BANNER, VIDEO} from '../src/mediaTypes'; -import { ajax } from '../src/ajax'; -import {Renderer} from '../src/Renderer'; - -const SUPPORTED_AD_TYPES = [BANNER, VIDEO]; -const BIDDER_CODE = 'advertly'; -const DOMAIN = ''; -const RENDERER_URL = '//acdn.adnxs.com/video/outstream/ANOutstreamVideo.js'; - -function isBidRequestValid(bid) { - return (typeof bid.params !== 'undefined' && parseInt(utils.getValue(bid.params, 'publisherId')) > 0); -} - -function buildRequests(validBidRequests) { - return { - method: 'POST', - url: DOMAIN + 'www/admin/plugins/Prebid/getAd.php', - options: { - withCredentials: false, - crossOrigin: true - }, - data: validBidRequests, - }; -} - -function interpretResponse(serverResponse, request) { - const response = serverResponse.body; - const bidResponses = []; - var bidRequestResponses = []; - - utils._each(response, function(bidAd) { - bidAd.adResponse = { - content: bidAd.vastXml, - height: bidAd.height, - width: bidAd.width - }; - bidAd.ttl = config.getConfig('_bidderTimeout') - bidAd.renderer = bidAd.context === 'outstream' ? createRenderer(bidAd, { - id: bidAd.adUnitCode, - url: RENDERER_URL - }, bidAd.adUnitCode) : undefined; - bidResponses.push(bidAd); - }); - - bidRequestResponses.push({ - function: 'saveResponses', - request: request, - response: bidResponses - }); - sendResponseToServer(bidRequestResponses); - return bidResponses; -} - -function outstreamRender(bidAd) { - bidAd.renderer.push(() => { - window.ANOutstreamVideo.renderAd({ - sizes: [bidAd.width, bidAd.height], - width: bidAd.width, - height: bidAd.height, - targetId: bidAd.adUnitCode, - adResponse: bidAd.adResponse, - rendererOptions: { - showVolume: false, - allowFullscreen: false - } - }); - }); -} - -function createRenderer(bidAd, rendererParams, adUnitCode) { - const renderer = Renderer.install({ - id: rendererParams.id, - url: rendererParams.url, - loaded: false, - config: {'player_height': bidAd.height, 'player_width': bidAd.width}, - adUnitCode - }); - try { - renderer.setRender(outstreamRender); - } catch (err) { - utils.logWarn('Prebid Error calling setRender on renderer', err); - } - return renderer; -} - -function onBidWon(bid) { - let wonBids = []; - wonBids.push(bid); - wonBids[0].function = 'onBidWon'; - sendResponseToServer(wonBids); -} - -function onTimeout(details) { - details.unshift({ 'function': 'onTimeout' }); - sendResponseToServer(details); -} - -function sendResponseToServer(data) { - ajax(DOMAIN + 'www/admin/plugins/Prebid/tracking/track.php', null, JSON.stringify(data), { - withCredentials: false, - method: 'POST', - crossOrigin: true - }); -} - -function getUserSyncs(syncOptions) { - if (syncOptions.iframeEnabled) { - return [{ - type: 'iframe', - url: DOMAIN + 'www/admin/plugins/Prebid/userSync.php' - }]; - } -} - -export const spec = { - code: BIDDER_CODE, - supportedMediaTypes: SUPPORTED_AD_TYPES, - isBidRequestValid, - buildRequests, - interpretResponse, - getUserSyncs, - onBidWon, - onTimeout -}; - -registerBidder(spec); From 6d2bed6b91a2498d42e747af68a87e45bcc60996 Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Thu, 26 Sep 2019 16:00:35 +0530 Subject: [PATCH 04/40] Delete advertlyBidAdapter.md --- modules/advertlyBidAdapter.md | 50 ----------------------------------- 1 file changed, 50 deletions(-) delete mode 100644 modules/advertlyBidAdapter.md diff --git a/modules/advertlyBidAdapter.md b/modules/advertlyBidAdapter.md deleted file mode 100644 index fc3573bd28c..00000000000 --- a/modules/advertlyBidAdapter.md +++ /dev/null @@ -1,50 +0,0 @@ -# Overview - -``` -Module Name: Advertly Bid Adapter -Module Type: Bidder Adapter -Maintainer : support@djaxtech.com -``` - -# Description - -Connects to Advertly Ad Server for bids. - -advertly bid adapter supports Banner and Video. - -# Test Parameters -``` - var adUnits = [ - //bannner object - { - code: 'banner-ad-slot', - mediaTypes: { - banner: { - sizes: [[300, 250], [300,600]], - } - }, - bids: [{ - bidder: 'advertly', - params: { - publisherId: 2 - } - }] - - }, - //video object - { - code: 'video-ad-slot', - mediaTypes: { - video: { - context: 'instream', - playerSize: [640, 480], - }, - }, - bids: [{ - bidder: "advertly", - params: { - publisherId: 2 - } - }] - }]; -``` From f522044dd5584a74b6291d8a14580c05c167edc4 Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Thu, 26 Sep 2019 16:01:29 +0530 Subject: [PATCH 05/40] Delete advertlyBidAdapter_spec.js --- test/spec/advertlyBidAdapter_spec.js | 159 --------------------------- 1 file changed, 159 deletions(-) delete mode 100644 test/spec/advertlyBidAdapter_spec.js diff --git a/test/spec/advertlyBidAdapter_spec.js b/test/spec/advertlyBidAdapter_spec.js deleted file mode 100644 index c02a99b3905..00000000000 --- a/test/spec/advertlyBidAdapter_spec.js +++ /dev/null @@ -1,159 +0,0 @@ -import { expect } from 'chai'; -import { spec } from 'modules/advertlyBidAdapter'; - -const ENDPOINT = ''; - -describe('The Advertly bidding adapter', function () { - describe('isBidRequestValid', function () { - it('should return false when given an invalid bid', function () { - const bid = { - bidder: 'advertly', - }; - const isValid = spec.isBidRequestValid(bid); - expect(isValid).to.equal(false); - }); - - it('should return true when given a publisherId in bid', function () { - const bid = { - bidder: 'advertly', - params: { - publisherId: 2 - }, - }; - const isValid = spec.isBidRequestValid(bid); - expect(isValid).to.equal(true); - }); - }); - - describe('buildRequests', function () { - const bidRequests = [{ - 'bidder': 'advertly', - 'params': { - 'publisherId': 2 - }, - 'adUnitCode': 'adunit-code', - 'sizes': [ - [300, 250], - [300, 600] - ] - }]; - - const request = spec.buildRequests(bidRequests); - - it('sends bid request to our endpoint via POST', function () { - expect(request.method).to.equal('POST'); - }); - - it('check endpoint url', function () { - expect(request.url).to.equal(ENDPOINT) - }); - - it('sets the proper banner object', function () { - expect(bidRequests[0].params.publisherId).to.equal(2); - }) - }); - const response = { - body: [ - { - 'requestId': '2ee937f15015c6', - 'cpm': '0.2000', - 'width': 300, - 'height': 600, - 'creativeId': '4', - 'currency': 'USD', - 'netRevenue': true, - 'ad': 'ads.html', - 'mediaType': 'banner' - }, - { - 'requestId': '3e1af92622bdc', - 'cpm': '0.2000', - 'creativeId': '4', - 'context': 'outstream', - 'currency': 'USD', - 'netRevenue': true, - 'vastUrl': 'tezt.xml', - 'width': 640, - 'height': 480, - 'mediaType': 'video' - }] - }; - - const request = [ - { - 'bidder': 'advertly', - 'params': { - 'publisherId': 2 - }, - 'mediaTypes': { - 'banner': { - 'sizes': [ - [300, 600] - ] - } - }, - 'bidId': '2ee937f15015c6', - 'src': 'client', - }, - { - 'bidder': 'advertly', - 'params': { - 'publisherId': 2 - }, - 'mediaTypes': { - 'video': { - 'context': 'outstream', - 'playerSize': [ - [640, 480] - ] - } - }, - 'bidId': '3e1af92622bdc', - 'src': 'client', - } - ]; - - describe('interpretResponse', function () { - it('return empty array when no ad found', function () { - const response = {}; - const request = { bidRequests: [] }; - const bids = spec.interpretResponse(response, request); - expect(bids).to.have.lengthOf(0); - }); - - it('check response for banner and video', function () { - const bids = spec.interpretResponse(response, request); - expect(bids).to.have.lengthOf(2); - expect(bids[0].requestId).to.equal('2ee937f15015c6'); - expect(bids[0].cpm).to.equal('0.2000'); - expect(bids[1].cpm).to.equal('0.2000'); - expect(bids[0].width).to.equal(300); - expect(bids[0].height).to.equal(600); - expect(bids[1].vastUrl).to.not.equal(''); - expect(bids[0].ad).to.not.equal(''); - expect(bids[1].adResponse).to.not.equal(''); - expect(bids[1].renderer).not.to.be.an('undefined'); - }); - }); - - describe('On winning bid', function () { - const bids = spec.interpretResponse(response, request); - spec.onBidWon(bids); - }); - - describe('On bid Time out', function () { - const bids = spec.interpretResponse(response, request); - spec.onTimeout(bids); - }); - - describe('user sync', function () { - it('to check the user sync iframe', function () { - let syncs = spec.getUserSyncs({ - iframeEnabled: true - }); - expect(syncs).to.not.be.an('undefined'); - expect(syncs).to.have.lengthOf(1); - expect(syncs[0].type).to.equal('iframe'); - }); - }); -}); From aefefffb4e87e363b482d05f880621773b40f3f6 Mon Sep 17 00:00:00 2001 From: advertly Date: Thu, 10 Oct 2019 18:17:36 +0530 Subject: [PATCH 06/40] Advertly Adapter --- modules/advertlyBidAdapter.js | 129 +++++++++++++++ modules/advertlyBidAdapter.md | 50 ++++++ test/spec/modules/advertlyBidAdapter_spec.js | 159 +++++++++++++++++++ 3 files changed, 338 insertions(+) create mode 100755 modules/advertlyBidAdapter.js create mode 100755 modules/advertlyBidAdapter.md create mode 100755 test/spec/modules/advertlyBidAdapter_spec.js diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js new file mode 100755 index 00000000000..56751e75b61 --- /dev/null +++ b/modules/advertlyBidAdapter.js @@ -0,0 +1,129 @@ +import { registerBidder } from '../src/adapters/bidderFactory'; +import { config } from '../src/config'; +import * as utils from '../src/utils'; +import {BANNER, VIDEO} from '../src/mediaTypes'; +import { ajax } from '../src/ajax'; +import {Renderer} from '../src/Renderer'; + +const SUPPORTED_AD_TYPES = [BANNER, VIDEO]; +const BIDDER_CODE = 'advertly'; +const DOMAIN = 'http://ads.advertly.com/'; +const RENDERER_URL = '//acdn.adnxs.com/video/outstream/ANOutstreamVideo.js'; + +function isBidRequestValid(bid) { + return (typeof bid.params !== 'undefined' && parseInt(utils.getValue(bid.params, 'publisherId')) > 0); +} + +function buildRequests(validBidRequests) { + return { + method: 'POST', + url: DOMAIN + 'www/admin/plugins/Prebid/getAd.php', + options: { + withCredentials: false, + crossOrigin: true + }, + data: validBidRequests, + }; +} + +function interpretResponse(serverResponse, request) { + const response = serverResponse.body; + const bidResponses = []; + var bidRequestResponses = []; + + utils._each(response, function(bidAd) { + bidAd.adResponse = { + content: bidAd.vastXml, + height: bidAd.height, + width: bidAd.width + }; + bidAd.ttl = config.getConfig('_bidderTimeout') + bidAd.renderer = bidAd.context === 'outstream' ? createRenderer(bidAd, { + id: bidAd.adUnitCode, + url: RENDERER_URL + }, bidAd.adUnitCode) : undefined; + bidResponses.push(bidAd); + }); + + bidRequestResponses.push({ + function: 'saveResponses', + request: request, + response: bidResponses + }); + sendResponseToServer(bidRequestResponses); + return bidResponses; +} + +function outstreamRender(bidAd) { + bidAd.renderer.push(() => { + window.ANOutstreamVideo.renderAd({ + sizes: [bidAd.width, bidAd.height], + width: bidAd.width, + height: bidAd.height, + targetId: bidAd.adUnitCode, + adResponse: bidAd.adResponse, + rendererOptions: { + showVolume: false, + allowFullscreen: false + } + }); + }); +} + +function createRenderer(bidAd, rendererParams, adUnitCode) { + const renderer = Renderer.install({ + id: rendererParams.id, + url: rendererParams.url, + loaded: false, + config: {'player_height': bidAd.height, 'player_width': bidAd.width}, + adUnitCode + }); + try { + renderer.setRender(outstreamRender); + } catch (err) { + utils.logWarn('Prebid Error calling setRender on renderer', err); + } + return renderer; +} + +function onBidWon(bid) { + let wonBids = []; + wonBids.push(bid); + wonBids[0].function = 'onBidWon'; + sendResponseToServer(wonBids); +} + +function onTimeout(details) { + details.unshift({ 'function': 'onTimeout' }); + sendResponseToServer(details); +} + +function sendResponseToServer(data) { + ajax(DOMAIN + 'www/admin/plugins/Prebid/tracking/track.php', null, JSON.stringify(data), { + withCredentials: false, + method: 'POST', + crossOrigin: true + }); +} + +function getUserSyncs(syncOptions) { + if (syncOptions.iframeEnabled) { + return [{ + type: 'iframe', + url: DOMAIN + 'www/admin/plugins/Prebid/userSync.php' + }]; + } +} + +export const spec = { + code: BIDDER_CODE, + supportedMediaTypes: SUPPORTED_AD_TYPES, + isBidRequestValid, + buildRequests, + interpretResponse, + getUserSyncs, + onBidWon, + onTimeout +}; + +registerBidder(spec); diff --git a/modules/advertlyBidAdapter.md b/modules/advertlyBidAdapter.md new file mode 100755 index 00000000000..b6cc3bfe71d --- /dev/null +++ b/modules/advertlyBidAdapter.md @@ -0,0 +1,50 @@ +# Overview + +``` +Module Name: Advertly Bid Adapter +Module Type: Bidder Adapter +Maintainer : support@advertly.com +``` + +# Description + +Connects to Advertly Ad Server for bids. + +advertly bid adapter supports Banner and Video. + +# Test Parameters +``` + var adUnits = [ + //bannner object + { + code: 'banner-ad-slot', + mediaTypes: { + banner: { + sizes: [[300, 250], [300,600]], + } + }, + bids: [{ + bidder: 'advertly', + params: { + publisherId: 2 + } + }] + + }, + //video object + { + code: 'video-ad-slot', + mediaTypes: { + video: { + context: 'instream', + playerSize: [640, 480], + }, + }, + bids: [{ + bidder: "advertly", + params: { + publisherId: 2 + } + }] + }]; +``` diff --git a/test/spec/modules/advertlyBidAdapter_spec.js b/test/spec/modules/advertlyBidAdapter_spec.js new file mode 100755 index 00000000000..d1b7f55ea76 --- /dev/null +++ b/test/spec/modules/advertlyBidAdapter_spec.js @@ -0,0 +1,159 @@ +import { expect } from 'chai'; +import { spec } from 'modules/advertlyBidAdapter'; + +const ENDPOINT = 'http://ads.advertly.com/www/admin/plugins/Prebid/getAd.php'; + +describe('The Advertly bidding adapter', function () { + describe('isBidRequestValid', function () { + it('should return false when given an invalid bid', function () { + const bid = { + bidder: 'advertly', + }; + const isValid = spec.isBidRequestValid(bid); + expect(isValid).to.equal(false); + }); + + it('should return true when given a publisherId in bid', function () { + const bid = { + bidder: 'advertly', + params: { + publisherId: 2 + }, + }; + const isValid = spec.isBidRequestValid(bid); + expect(isValid).to.equal(true); + }); + }); + + describe('buildRequests', function () { + const bidRequests = [{ + 'bidder': 'advertly', + 'params': { + 'publisherId': 2 + }, + 'adUnitCode': 'adunit-code', + 'sizes': [ + [300, 250], + [300, 600] + ] + }]; + + const request = spec.buildRequests(bidRequests); + + it('sends bid request to our endpoint via POST', function () { + expect(request.method).to.equal('POST'); + }); + + it('check endpoint url', function () { + expect(request.url).to.equal(ENDPOINT) + }); + + it('sets the proper banner object', function () { + expect(bidRequests[0].params.publisherId).to.equal(2); + }) + }); + const response = { + body: [ + { + 'requestId': '2ee937f15015c6', + 'cpm': '0.2000', + 'width': 300, + 'height': 600, + 'creativeId': '4', + 'currency': 'USD', + 'netRevenue': true, + 'ad': 'ads.html', + 'mediaType': 'banner' + }, + { + 'requestId': '3e1af92622bdc', + 'cpm': '0.2000', + 'creativeId': '4', + 'context': 'outstream', + 'currency': 'USD', + 'netRevenue': true, + 'vastUrl': 'tezt.xml', + 'width': 640, + 'height': 480, + 'mediaType': 'video' + }] + }; + + const request = [ + { + 'bidder': 'advertly', + 'params': { + 'publisherId': 2 + }, + 'mediaTypes': { + 'banner': { + 'sizes': [ + [300, 600] + ] + } + }, + 'bidId': '2ee937f15015c6', + 'src': 'client', + }, + { + 'bidder': 'advertly', + 'params': { + 'publisherId': 2 + }, + 'mediaTypes': { + 'video': { + 'context': 'outstream', + 'playerSize': [ + [640, 480] + ] + } + }, + 'bidId': '3e1af92622bdc', + 'src': 'client', + } + ]; + + describe('interpretResponse', function () { + it('return empty array when no ad found', function () { + const response = {}; + const request = { bidRequests: [] }; + const bids = spec.interpretResponse(response, request); + expect(bids).to.have.lengthOf(0); + }); + + it('check response for banner and video', function () { + const bids = spec.interpretResponse(response, request); + expect(bids).to.have.lengthOf(2); + expect(bids[0].requestId).to.equal('2ee937f15015c6'); + expect(bids[0].cpm).to.equal('0.2000'); + expect(bids[1].cpm).to.equal('0.2000'); + expect(bids[0].width).to.equal(300); + expect(bids[0].height).to.equal(600); + expect(bids[1].vastUrl).to.not.equal(''); + expect(bids[0].ad).to.not.equal(''); + expect(bids[1].adResponse).to.not.equal(''); + expect(bids[1].renderer).not.to.be.an('undefined'); + }); + }); + + describe('On winning bid', function () { + const bids = spec.interpretResponse(response, request); + spec.onBidWon(bids); + }); + + describe('On bid Time out', function () { + const bids = spec.interpretResponse(response, request); + spec.onTimeout(bids); + }); + + describe('user sync', function () { + it('to check the user sync iframe', function () { + let syncs = spec.getUserSyncs({ + iframeEnabled: true + }); + expect(syncs).to.not.be.an('undefined'); + expect(syncs).to.have.lengthOf(1); + expect(syncs[0].type).to.equal('iframe'); + }); + }); +}); From 62d884a5c29d0d40264b3c54bf9b0a612f7f423d Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Thu, 10 Oct 2019 18:50:33 +0530 Subject: [PATCH 07/40] Update advertlyBidAdapter.md --- modules/advertlyBidAdapter.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/advertlyBidAdapter.md b/modules/advertlyBidAdapter.md index b6cc3bfe71d..15bb3499e0a 100755 --- a/modules/advertlyBidAdapter.md +++ b/modules/advertlyBidAdapter.md @@ -26,7 +26,7 @@ advertly bid adapter supports Banner and Video. bids: [{ bidder: 'advertly', params: { - publisherId: 2 + publisherId: 1 } }] @@ -43,7 +43,7 @@ advertly bid adapter supports Banner and Video. bids: [{ bidder: "advertly", params: { - publisherId: 2 + publisherId: 1 } }] }]; From 3e29911e629f7130d6e5085dd00e7aea060fdd23 Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Thu, 10 Oct 2019 18:52:16 +0530 Subject: [PATCH 08/40] Update advertlyBidAdapter_spec.js --- test/spec/modules/advertlyBidAdapter_spec.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/spec/modules/advertlyBidAdapter_spec.js b/test/spec/modules/advertlyBidAdapter_spec.js index d1b7f55ea76..7cfc1d9976e 100755 --- a/test/spec/modules/advertlyBidAdapter_spec.js +++ b/test/spec/modules/advertlyBidAdapter_spec.js @@ -17,7 +17,7 @@ describe('The Advertly bidding adapter', function () { const bid = { bidder: 'advertly', params: { - publisherId: 2 + publisherId: 1 }, }; const isValid = spec.isBidRequestValid(bid); @@ -29,7 +29,7 @@ describe('The Advertly bidding adapter', function () { const bidRequests = [{ 'bidder': 'advertly', 'params': { - 'publisherId': 2 + 'publisherId': 1 }, 'adUnitCode': 'adunit-code', 'sizes': [ @@ -83,7 +83,7 @@ describe('The Advertly bidding adapter', function () { { 'bidder': 'advertly', 'params': { - 'publisherId': 2 + 'publisherId': 1 }, 'mediaTypes': { 'banner': { @@ -98,7 +98,7 @@ describe('The Advertly bidding adapter', function () { { 'bidder': 'advertly', 'params': { - 'publisherId': 2 + 'publisherId': 1 }, 'mediaTypes': { 'video': { From 1fec69100fc84837f0d3ac23f80f9170b36839dc Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Fri, 11 Oct 2019 10:51:06 +0530 Subject: [PATCH 09/40] Update advertlyBidAdapter.md --- modules/advertlyBidAdapter.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/advertlyBidAdapter.md b/modules/advertlyBidAdapter.md index 15bb3499e0a..b6cc3bfe71d 100755 --- a/modules/advertlyBidAdapter.md +++ b/modules/advertlyBidAdapter.md @@ -26,7 +26,7 @@ advertly bid adapter supports Banner and Video. bids: [{ bidder: 'advertly', params: { - publisherId: 1 + publisherId: 2 } }] @@ -43,7 +43,7 @@ advertly bid adapter supports Banner and Video. bids: [{ bidder: "advertly", params: { - publisherId: 1 + publisherId: 2 } }] }]; From 995929f251926e9260a7a75a0ccfdd5778e3fd3d Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Fri, 11 Oct 2019 10:52:05 +0530 Subject: [PATCH 10/40] Update advertlyBidAdapter_spec.js --- test/spec/modules/advertlyBidAdapter_spec.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/spec/modules/advertlyBidAdapter_spec.js b/test/spec/modules/advertlyBidAdapter_spec.js index 7cfc1d9976e..d1b7f55ea76 100755 --- a/test/spec/modules/advertlyBidAdapter_spec.js +++ b/test/spec/modules/advertlyBidAdapter_spec.js @@ -17,7 +17,7 @@ describe('The Advertly bidding adapter', function () { const bid = { bidder: 'advertly', params: { - publisherId: 1 + publisherId: 2 }, }; const isValid = spec.isBidRequestValid(bid); @@ -29,7 +29,7 @@ describe('The Advertly bidding adapter', function () { const bidRequests = [{ 'bidder': 'advertly', 'params': { - 'publisherId': 1 + 'publisherId': 2 }, 'adUnitCode': 'adunit-code', 'sizes': [ @@ -83,7 +83,7 @@ describe('The Advertly bidding adapter', function () { { 'bidder': 'advertly', 'params': { - 'publisherId': 1 + 'publisherId': 2 }, 'mediaTypes': { 'banner': { @@ -98,7 +98,7 @@ describe('The Advertly bidding adapter', function () { { 'bidder': 'advertly', 'params': { - 'publisherId': 1 + 'publisherId': 2 }, 'mediaTypes': { 'video': { From 097d70a5483f17c345b146793571a5dadb7151fc Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Thu, 31 Oct 2019 18:12:41 +0530 Subject: [PATCH 11/40] Update advertlyBidAdapter.js --- modules/advertlyBidAdapter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index 56751e75b61..dfa8d6d93e0 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -7,7 +7,7 @@ import {Renderer} from '../src/Renderer'; const SUPPORTED_AD_TYPES = [BANNER, VIDEO]; const BIDDER_CODE = 'advertly'; -const DOMAIN = 'http://ads.advertly.com/'; +const DOMAIN = '//api.advertly.com/'; const RENDERER_URL = '//acdn.adnxs.com/video/outstream/ANOutstreamVideo.js'; function isBidRequestValid(bid) { From c6013e27cbbb6bf6436c627319fbc6fa856ccd02 Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Thu, 31 Oct 2019 18:13:31 +0530 Subject: [PATCH 12/40] Update advertlyBidAdapter_spec.js --- test/spec/modules/advertlyBidAdapter_spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/spec/modules/advertlyBidAdapter_spec.js b/test/spec/modules/advertlyBidAdapter_spec.js index d1b7f55ea76..71a6ce5a166 100755 --- a/test/spec/modules/advertlyBidAdapter_spec.js +++ b/test/spec/modules/advertlyBidAdapter_spec.js @@ -1,7 +1,7 @@ import { expect } from 'chai'; import { spec } from 'modules/advertlyBidAdapter'; -const ENDPOINT = 'http://ads.advertly.com/www/admin/plugins/Prebid/getAd.php'; +const ENDPOINT = '//api.advertly.com/www/admin/plugins/Prebid/getAd.php'; describe('The Advertly bidding adapter', function () { describe('isBidRequestValid', function () { From 3e8b8e35d8c225f1bec1ff9fa96edf11520cbf2a Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Thu, 31 Oct 2019 18:15:29 +0530 Subject: [PATCH 13/40] Update advertlyBidAdapter_spec.js --- test/spec/modules/advertlyBidAdapter_spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/spec/modules/advertlyBidAdapter_spec.js b/test/spec/modules/advertlyBidAdapter_spec.js index 71a6ce5a166..0226884fc01 100755 --- a/test/spec/modules/advertlyBidAdapter_spec.js +++ b/test/spec/modules/advertlyBidAdapter_spec.js @@ -1,7 +1,7 @@ import { expect } from 'chai'; import { spec } from 'modules/advertlyBidAdapter'; -const ENDPOINT = '//api.advertly.com/www/admin/plugins/Prebid/getAd.php'; +const ENDPOINT = 'http://api.advertly.com/www/admin/plugins/Prebid/getAd.php'; describe('The Advertly bidding adapter', function () { describe('isBidRequestValid', function () { From 7e884f64a98ed51fd3700672ef1d433263900443 Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Thu, 31 Oct 2019 18:16:13 +0530 Subject: [PATCH 14/40] Update advertlyBidAdapter.js --- modules/advertlyBidAdapter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index dfa8d6d93e0..46d434485e0 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -7,7 +7,7 @@ import {Renderer} from '../src/Renderer'; const SUPPORTED_AD_TYPES = [BANNER, VIDEO]; const BIDDER_CODE = 'advertly'; -const DOMAIN = '//api.advertly.com/'; +const DOMAIN = 'http://api.advertly.com/'; const RENDERER_URL = '//acdn.adnxs.com/video/outstream/ANOutstreamVideo.js'; function isBidRequestValid(bid) { From 268b307b29e1a3244d74b82bb5a7542995592432 Mon Sep 17 00:00:00 2001 From: advertly Date: Mon, 25 Nov 2019 17:22:45 +0530 Subject: [PATCH 15/40] Update Advertly --- integrationExamples/gpt/hello_world.html | 37 ++++++++++++++++---- modules/advertlyBidAdapter.js | 2 +- modules/advertlyBidAdapter.md | 6 ++-- test/spec/modules/advertlyBidAdapter_spec.js | 12 +++---- 4 files changed, 40 insertions(+), 17 deletions(-) mode change 100644 => 100755 integrationExamples/gpt/hello_world.html diff --git a/integrationExamples/gpt/hello_world.html b/integrationExamples/gpt/hello_world.html old mode 100644 new mode 100755 index 337c762adc5..7850ea7dce1 --- a/integrationExamples/gpt/hello_world.html +++ b/integrationExamples/gpt/hello_world.html @@ -6,14 +6,14 @@ NOTE that many ad servers won't send back an ad if the URL is localhost... so you might need to set an alias in your /etc/hosts file so that you can load this page from a different domain. --> - +​ +
Outstream Video
+​ +
+ +
diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index 46d434485e0..331f51886b0 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -6,7 +6,7 @@ import { ajax } from '../src/ajax'; import {Renderer} from '../src/Renderer'; const SUPPORTED_AD_TYPES = [BANNER, VIDEO]; -const BIDDER_CODE = 'advertly'; +const BIDDER_CODE = 'ADVERTLY'; const DOMAIN = 'http://api.advertly.com/'; const RENDERER_URL = '//acdn.adnxs.com/video/outstream/ANOutstreamVideo.js'; diff --git a/modules/advertlyBidAdapter.md b/modules/advertlyBidAdapter.md index b6cc3bfe71d..a076d184e12 100755 --- a/modules/advertlyBidAdapter.md +++ b/modules/advertlyBidAdapter.md @@ -1,7 +1,7 @@ # Overview ``` -Module Name: Advertly Bid Adapter +Module Name: ADVERTLY Bid Adapter Module Type: Bidder Adapter Maintainer : support@advertly.com ``` @@ -24,7 +24,7 @@ advertly bid adapter supports Banner and Video. } }, bids: [{ - bidder: 'advertly', + bidder: 'ADVERTLY', params: { publisherId: 2 } @@ -41,7 +41,7 @@ advertly bid adapter supports Banner and Video. }, }, bids: [{ - bidder: "advertly", + bidder: "ADVERTLY", params: { publisherId: 2 } diff --git a/test/spec/modules/advertlyBidAdapter_spec.js b/test/spec/modules/advertlyBidAdapter_spec.js index 0226884fc01..2091a39a615 100755 --- a/test/spec/modules/advertlyBidAdapter_spec.js +++ b/test/spec/modules/advertlyBidAdapter_spec.js @@ -3,11 +3,11 @@ import { spec } from 'modules/advertlyBidAdapter'; const ENDPOINT = 'http://api.advertly.com/www/admin/plugins/Prebid/getAd.php'; -describe('The Advertly bidding adapter', function () { +describe('The ADVERTLY bidding adapter', function () { describe('isBidRequestValid', function () { it('should return false when given an invalid bid', function () { const bid = { - bidder: 'advertly', + bidder: 'ADVERTLY', }; const isValid = spec.isBidRequestValid(bid); expect(isValid).to.equal(false); @@ -15,7 +15,7 @@ describe('The Advertly bidding adapter', function () { it('should return true when given a publisherId in bid', function () { const bid = { - bidder: 'advertly', + bidder: 'ADVERTLY', params: { publisherId: 2 }, @@ -27,7 +27,7 @@ describe('The Advertly bidding adapter', function () { describe('buildRequests', function () { const bidRequests = [{ - 'bidder': 'advertly', + 'bidder': 'ADVERTLY', 'params': { 'publisherId': 2 }, @@ -81,7 +81,7 @@ describe('The Advertly bidding adapter', function () { const request = [ { - 'bidder': 'advertly', + 'bidder': 'ADVERTLY', 'params': { 'publisherId': 2 }, @@ -96,7 +96,7 @@ describe('The Advertly bidding adapter', function () { 'src': 'client', }, { - 'bidder': 'advertly', + 'bidder': 'ADVERTLY', 'params': { 'publisherId': 2 }, From d92f1dda72de5700eb59cb2dcb6451d0a03ac479 Mon Sep 17 00:00:00 2001 From: advertly Date: Mon, 25 Nov 2019 18:20:17 +0530 Subject: [PATCH 16/40] Advertly Bidder Adapter Files --- integrationExamples/gpt/hello_world.html | 37 ++++---------------- modules/advertlyBidAdapter.js | 2 +- modules/advertlyBidAdapter.md | 6 ++-- test/spec/modules/advertlyBidAdapter_spec.js | 12 +++---- 4 files changed, 17 insertions(+), 40 deletions(-) diff --git a/integrationExamples/gpt/hello_world.html b/integrationExamples/gpt/hello_world.html index 7850ea7dce1..337c762adc5 100755 --- a/integrationExamples/gpt/hello_world.html +++ b/integrationExamples/gpt/hello_world.html @@ -6,14 +6,14 @@ NOTE that many ad servers won't send back an ad if the URL is localhost... so you might need to set an alias in your /etc/hosts file so that you can load this page from a different domain. --> -​ + -
Outstream Video
-​ -
- -
diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index 331f51886b0..46d434485e0 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -6,7 +6,7 @@ import { ajax } from '../src/ajax'; import {Renderer} from '../src/Renderer'; const SUPPORTED_AD_TYPES = [BANNER, VIDEO]; -const BIDDER_CODE = 'ADVERTLY'; +const BIDDER_CODE = 'advertly'; const DOMAIN = 'http://api.advertly.com/'; const RENDERER_URL = '//acdn.adnxs.com/video/outstream/ANOutstreamVideo.js'; diff --git a/modules/advertlyBidAdapter.md b/modules/advertlyBidAdapter.md index a076d184e12..b6cc3bfe71d 100755 --- a/modules/advertlyBidAdapter.md +++ b/modules/advertlyBidAdapter.md @@ -1,7 +1,7 @@ # Overview ``` -Module Name: ADVERTLY Bid Adapter +Module Name: Advertly Bid Adapter Module Type: Bidder Adapter Maintainer : support@advertly.com ``` @@ -24,7 +24,7 @@ advertly bid adapter supports Banner and Video. } }, bids: [{ - bidder: 'ADVERTLY', + bidder: 'advertly', params: { publisherId: 2 } @@ -41,7 +41,7 @@ advertly bid adapter supports Banner and Video. }, }, bids: [{ - bidder: "ADVERTLY", + bidder: "advertly", params: { publisherId: 2 } diff --git a/test/spec/modules/advertlyBidAdapter_spec.js b/test/spec/modules/advertlyBidAdapter_spec.js index 2091a39a615..0226884fc01 100755 --- a/test/spec/modules/advertlyBidAdapter_spec.js +++ b/test/spec/modules/advertlyBidAdapter_spec.js @@ -3,11 +3,11 @@ import { spec } from 'modules/advertlyBidAdapter'; const ENDPOINT = 'http://api.advertly.com/www/admin/plugins/Prebid/getAd.php'; -describe('The ADVERTLY bidding adapter', function () { +describe('The Advertly bidding adapter', function () { describe('isBidRequestValid', function () { it('should return false when given an invalid bid', function () { const bid = { - bidder: 'ADVERTLY', + bidder: 'advertly', }; const isValid = spec.isBidRequestValid(bid); expect(isValid).to.equal(false); @@ -15,7 +15,7 @@ describe('The ADVERTLY bidding adapter', function () { it('should return true when given a publisherId in bid', function () { const bid = { - bidder: 'ADVERTLY', + bidder: 'advertly', params: { publisherId: 2 }, @@ -27,7 +27,7 @@ describe('The ADVERTLY bidding adapter', function () { describe('buildRequests', function () { const bidRequests = [{ - 'bidder': 'ADVERTLY', + 'bidder': 'advertly', 'params': { 'publisherId': 2 }, @@ -81,7 +81,7 @@ describe('The ADVERTLY bidding adapter', function () { const request = [ { - 'bidder': 'ADVERTLY', + 'bidder': 'advertly', 'params': { 'publisherId': 2 }, @@ -96,7 +96,7 @@ describe('The ADVERTLY bidding adapter', function () { 'src': 'client', }, { - 'bidder': 'ADVERTLY', + 'bidder': 'advertly', 'params': { 'publisherId': 2 }, From 9b3de3d66126db40d06523f9897c7f4481242756 Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Wed, 4 Dec 2019 17:44:27 +0530 Subject: [PATCH 17/40] Updated with create the new object Updated with create the new object instead of modifying response data --- modules/advertlyBidAdapter.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index 46d434485e0..6f0ce107dc4 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -30,19 +30,19 @@ function interpretResponse(serverResponse, request) { const response = serverResponse.body; const bidResponses = []; var bidRequestResponses = []; - - utils._each(response, function(bidAd) { - bidAd.adResponse = { + let bnd = {}; + utils._each(response, function(bidAd) {bnd = bidAd; + bnd.adResponse = { content: bidAd.vastXml, height: bidAd.height, width: bidAd.width }; - bidAd.ttl = config.getConfig('_bidderTimeout') - bidAd.renderer = bidAd.context === 'outstream' ? createRenderer(bidAd, { + bnd.ttl = config.getConfig('_bidderTimeout') + bnd.renderer = bidAd.context === 'outstream' ? createRenderer(bidAd, { id: bidAd.adUnitCode, url: RENDERER_URL }, bidAd.adUnitCode) : undefined; - bidResponses.push(bidAd); + bidResponses.push(bnd); }); bidRequestResponses.push({ From 93b830e4183c12d25e1e42c7c9b28739b581a9e8 Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Wed, 4 Dec 2019 17:58:57 +0530 Subject: [PATCH 18/40] Updated with create the new object Updated with create the new object instead of modifying response data --- modules/advertlyBidAdapter.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index 6f0ce107dc4..99fb0e154ea 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -30,8 +30,8 @@ function interpretResponse(serverResponse, request) { const response = serverResponse.body; const bidResponses = []; var bidRequestResponses = []; - let bnd = {}; - utils._each(response, function(bidAd) {bnd = bidAd; + let bnd = {}; + utils._each(response, function(bidAd) { bnd = bidAd; bnd.adResponse = { content: bidAd.vastXml, height: bidAd.height, From 10d3cee65161fc584d39f4642c91c428648fc493 Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Wed, 4 Dec 2019 18:06:17 +0530 Subject: [PATCH 19/40] Updated with create the new object Updated with create the new object instead of modifying response data --- modules/advertlyBidAdapter.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index 99fb0e154ea..26c8569fd33 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -30,8 +30,9 @@ function interpretResponse(serverResponse, request) { const response = serverResponse.body; const bidResponses = []; var bidRequestResponses = []; - let bnd = {}; - utils._each(response, function(bidAd) { bnd = bidAd; + let bnd = {}; + utils._each(response, function(bidAd) { + bnd = bidAd; bnd.adResponse = { content: bidAd.vastXml, height: bidAd.height, @@ -42,7 +43,7 @@ function interpretResponse(serverResponse, request) { id: bidAd.adUnitCode, url: RENDERER_URL }, bidAd.adUnitCode) : undefined; - bidResponses.push(bnd); + bidResponses.push(bnd); }); bidRequestResponses.push({ From 8bf8519418237c4b3f0e7f62529f01702e022d4e Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Wed, 4 Dec 2019 18:11:12 +0530 Subject: [PATCH 20/40] Updated with create the new object Updated with create the new object instead of modifying response data From 4bde92d6fea8a687c8bcb1d24cd1edaadaa9251a Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Wed, 4 Dec 2019 18:23:08 +0530 Subject: [PATCH 21/40] Updated with create the new object Updated with create the new object instead of modifying response data --- modules/advertlyBidAdapter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index 26c8569fd33..d716d59729f 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -32,7 +32,7 @@ function interpretResponse(serverResponse, request) { var bidRequestResponses = []; let bnd = {}; utils._each(response, function(bidAd) { - bnd = bidAd; + bnd = bidAd; bnd.adResponse = { content: bidAd.vastXml, height: bidAd.height, From e09433ee2ed8e423f27f26b7c9a2ff0407c6c2e1 Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Wed, 4 Dec 2019 18:26:48 +0530 Subject: [PATCH 22/40] Updated with create the new object Updated with create the new object instead of modifying response data --- modules/advertlyBidAdapter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index d716d59729f..71e443be9ac 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -31,7 +31,7 @@ function interpretResponse(serverResponse, request) { const bidResponses = []; var bidRequestResponses = []; let bnd = {}; - utils._each(response, function(bidAd) { + utils._each(response, function(bidAd) { bnd = bidAd; bnd.adResponse = { content: bidAd.vastXml, From a1076fee67852181429cd78f58963c55c7dba517 Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Wed, 4 Dec 2019 18:29:15 +0530 Subject: [PATCH 23/40] Updated with create the new object Updated with create the new object instead of modifying response data --- modules/advertlyBidAdapter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index 71e443be9ac..cbec1cec7f1 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -32,7 +32,7 @@ function interpretResponse(serverResponse, request) { var bidRequestResponses = []; let bnd = {}; utils._each(response, function(bidAd) { - bnd = bidAd; + bnd = bidAd; bnd.adResponse = { content: bidAd.vastXml, height: bidAd.height, From 49c66d370c033a0478859b7f8c4d775b04f1048b Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Thu, 5 Dec 2019 16:09:49 +0530 Subject: [PATCH 24/40] Update with new changes Update with new changes --- modules/advertlyBidAdapter.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index cbec1cec7f1..7e1cc371e07 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -30,8 +30,10 @@ function interpretResponse(serverResponse, request) { const response = serverResponse.body; const bidResponses = []; var bidRequestResponses = []; - let bnd = {}; + utils._each(response, function(bidAd) { + let bnd = {}; + Object.assign(bnd, bidAd); bnd = bidAd; bnd.adResponse = { content: bidAd.vastXml, From 2d9ad1cebba3a503d87ffbf08b63f0896d6f3b2d Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Thu, 5 Dec 2019 16:14:12 +0530 Subject: [PATCH 25/40] Update with new changes --- modules/advertlyBidAdapter.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index 7e1cc371e07..abdd15effab 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -30,9 +30,8 @@ function interpretResponse(serverResponse, request) { const response = serverResponse.body; const bidResponses = []; var bidRequestResponses = []; - utils._each(response, function(bidAd) { - let bnd = {}; + let bnd = {}; Object.assign(bnd, bidAd); bnd = bidAd; bnd.adResponse = { From 7bc73842e72fb2e7487d765021363625d164ec05 Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Thu, 5 Dec 2019 16:23:26 +0530 Subject: [PATCH 26/40] update with new changes --- modules/advertlyBidAdapter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index abdd15effab..449a0fe9032 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -31,7 +31,7 @@ function interpretResponse(serverResponse, request) { const bidResponses = []; var bidRequestResponses = []; utils._each(response, function(bidAd) { - let bnd = {}; + let bnd ={}; Object.assign(bnd, bidAd); bnd = bidAd; bnd.adResponse = { From eea459526680df764519cc03d0b20c24d9c3ec5b Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Thu, 5 Dec 2019 16:26:53 +0530 Subject: [PATCH 27/40] Update with new Changes --- modules/advertlyBidAdapter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index 449a0fe9032..abdd15effab 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -31,7 +31,7 @@ function interpretResponse(serverResponse, request) { const bidResponses = []; var bidRequestResponses = []; utils._each(response, function(bidAd) { - let bnd ={}; + let bnd = {}; Object.assign(bnd, bidAd); bnd = bidAd; bnd.adResponse = { From 26ea6f01a441f34cab312107d0a208ebe4222a07 Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Tue, 10 Dec 2019 09:59:59 +0530 Subject: [PATCH 28/40] update advertly --- modules/advertlyBidAdapter.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index abdd15effab..5fcd92f9829 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -41,7 +41,6 @@ function interpretResponse(serverResponse, request) { }; bnd.ttl = config.getConfig('_bidderTimeout') bnd.renderer = bidAd.context === 'outstream' ? createRenderer(bidAd, { - id: bidAd.adUnitCode, url: RENDERER_URL }, bidAd.adUnitCode) : undefined; bidResponses.push(bnd); @@ -74,7 +73,7 @@ function outstreamRender(bidAd) { function createRenderer(bidAd, rendererParams, adUnitCode) { const renderer = Renderer.install({ - id: rendererParams.id, + id: adUnitCode, url: rendererParams.url, loaded: false, config: {'player_height': bidAd.height, 'player_width': bidAd.width}, From 9f01e01504ea8257809f35de2676a211df7cb097 Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Tue, 10 Dec 2019 10:18:10 +0530 Subject: [PATCH 29/40] New updates --- modules/advertlyBidAdapter.js | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index 5fcd92f9829..62ba66f532c 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -40,9 +40,7 @@ function interpretResponse(serverResponse, request) { width: bidAd.width }; bnd.ttl = config.getConfig('_bidderTimeout') - bnd.renderer = bidAd.context === 'outstream' ? createRenderer(bidAd, { - url: RENDERER_URL - }, bidAd.adUnitCode) : undefined; + bnd.renderer = bidAd.context === 'outstream' ? createRenderer(bidAd,RENDERER_URL ) : undefined; bidResponses.push(bnd); }); @@ -71,13 +69,13 @@ function outstreamRender(bidAd) { }); } -function createRenderer(bidAd, rendererParams, adUnitCode) { +function createRenderer(bidAd, url) { const renderer = Renderer.install({ - id: adUnitCode, - url: rendererParams.url, + id: bidAd.adUnitCode, + url: url , loaded: false, config: {'player_height': bidAd.height, 'player_width': bidAd.width}, - adUnitCode + bidAd.adUnitCode }); try { renderer.setRender(outstreamRender); From 3b546734b9c710f9285ccbe2a6d00e292c117778 Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Tue, 10 Dec 2019 10:24:59 +0530 Subject: [PATCH 30/40] update advertly --- modules/advertlyBidAdapter.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index 62ba66f532c..a809ff75b5e 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -40,7 +40,7 @@ function interpretResponse(serverResponse, request) { width: bidAd.width }; bnd.ttl = config.getConfig('_bidderTimeout') - bnd.renderer = bidAd.context === 'outstream' ? createRenderer(bidAd,RENDERER_URL ) : undefined; + bnd.renderer = bidAd.context === 'outstream' ? createRenderer(bidAd,RENDERER_URL, bidAd.adUnitCode) : undefined; bidResponses.push(bnd); }); @@ -69,13 +69,13 @@ function outstreamRender(bidAd) { }); } -function createRenderer(bidAd, url) { +function createRenderer(bidAd, url,adUnitCode) { const renderer = Renderer.install({ id: bidAd.adUnitCode, url: url , loaded: false, config: {'player_height': bidAd.height, 'player_width': bidAd.width}, - bidAd.adUnitCode + adUnitCode }); try { renderer.setRender(outstreamRender); From 557c812cabc0d808d75a78328e84b7ceab84047c Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Tue, 10 Dec 2019 10:34:05 +0530 Subject: [PATCH 31/40] update advertly --- modules/advertlyBidAdapter.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index a809ff75b5e..515a5822e47 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -40,7 +40,7 @@ function interpretResponse(serverResponse, request) { width: bidAd.width }; bnd.ttl = config.getConfig('_bidderTimeout') - bnd.renderer = bidAd.context === 'outstream' ? createRenderer(bidAd,RENDERER_URL, bidAd.adUnitCode) : undefined; + bnd.renderer = bidAd.context === 'outstream' ? createRenderer(bidAd, RENDERER_URL) : undefined; bidResponses.push(bnd); }); @@ -69,13 +69,13 @@ function outstreamRender(bidAd) { }); } -function createRenderer(bidAd, url,adUnitCode) { +function createRenderer(bidAd, url) { const renderer = Renderer.install({ id: bidAd.adUnitCode, - url: url , + url: url, loaded: false, config: {'player_height': bidAd.height, 'player_width': bidAd.width}, - adUnitCode + bidAd.adUnitCode }); try { renderer.setRender(outstreamRender); From 832069a6810f0c6bbe88b89e253f91c53c2444cb Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Tue, 10 Dec 2019 10:36:59 +0530 Subject: [PATCH 32/40] update advertly --- modules/advertlyBidAdapter.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index 515a5822e47..05f2f19c5e9 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -40,7 +40,7 @@ function interpretResponse(serverResponse, request) { width: bidAd.width }; bnd.ttl = config.getConfig('_bidderTimeout') - bnd.renderer = bidAd.context === 'outstream' ? createRenderer(bidAd, RENDERER_URL) : undefined; + bnd.renderer = bidAd.context === 'outstream' ? createRenderer(bidAd, RENDERER_URL, bidAd.adUnitCode) : undefined; bidResponses.push(bnd); }); @@ -69,13 +69,13 @@ function outstreamRender(bidAd) { }); } -function createRenderer(bidAd, url) { +function createRenderer(bidAd, url, adUnitCode) { const renderer = Renderer.install({ id: bidAd.adUnitCode, url: url, loaded: false, config: {'player_height': bidAd.height, 'player_width': bidAd.width}, - bidAd.adUnitCode + adUnitCode }); try { renderer.setRender(outstreamRender); From 2882515b11913b2d220088857a35edcebb121d42 Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Mon, 16 Dec 2019 18:12:27 +0530 Subject: [PATCH 33/40] update advertly --- modules/advertlyBidAdapter.js | 1 - 1 file changed, 1 deletion(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index 05f2f19c5e9..7bd82a30f30 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -33,7 +33,6 @@ function interpretResponse(serverResponse, request) { utils._each(response, function(bidAd) { let bnd = {}; Object.assign(bnd, bidAd); - bnd = bidAd; bnd.adResponse = { content: bidAd.vastXml, height: bidAd.height, From ee4ca8d4b4fd9fd45b33ae5fe31ed896adf8fb1e Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Mon, 16 Dec 2019 18:15:13 +0530 Subject: [PATCH 34/40] Update advertlyBidAdapter.js --- modules/advertlyBidAdapter.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index 7bd82a30f30..dc89638cdb9 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -39,7 +39,7 @@ function interpretResponse(serverResponse, request) { width: bidAd.width }; bnd.ttl = config.getConfig('_bidderTimeout') - bnd.renderer = bidAd.context === 'outstream' ? createRenderer(bidAd, RENDERER_URL, bidAd.adUnitCode) : undefined; + bnd.renderer = bidAd.context === 'outstream' ? createRenderer(bidAd, RENDERER_URL) : undefined; bidResponses.push(bnd); }); @@ -74,7 +74,7 @@ function createRenderer(bidAd, url, adUnitCode) { url: url, loaded: false, config: {'player_height': bidAd.height, 'player_width': bidAd.width}, - adUnitCode + bidAd.adUnitCode }); try { renderer.setRender(outstreamRender); From d2bfd73d40e8eb7999efa30ee6744683063e8fdb Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Mon, 16 Dec 2019 18:15:33 +0530 Subject: [PATCH 35/40] Update advertlyBidAdapter.js --- modules/advertlyBidAdapter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index dc89638cdb9..c918cf7fb2b 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -68,7 +68,7 @@ function outstreamRender(bidAd) { }); } -function createRenderer(bidAd, url, adUnitCode) { +function createRenderer(bidAd, url) { const renderer = Renderer.install({ id: bidAd.adUnitCode, url: url, From 6206f2c81decc79348774a68e594d640157c2a25 Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Tue, 17 Dec 2019 10:05:59 +0530 Subject: [PATCH 36/40] Update advertlyBidAdapter.js --- modules/advertlyBidAdapter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index c918cf7fb2b..8b2e0994476 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -74,7 +74,7 @@ function createRenderer(bidAd, url) { url: url, loaded: false, config: {'player_height': bidAd.height, 'player_width': bidAd.width}, - bidAd.adUnitCode + adUnitCode: bidAd.adUnitCode }); try { renderer.setRender(outstreamRender); From e035ef3cf80ecc0d85d6db256b7393a24500305e Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Thu, 26 Dec 2019 12:26:22 +0530 Subject: [PATCH 37/40] updated advertly --- modules/advertlyBidAdapter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index 8b2e0994476..00690a70b0a 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -7,7 +7,7 @@ import {Renderer} from '../src/Renderer'; const SUPPORTED_AD_TYPES = [BANNER, VIDEO]; const BIDDER_CODE = 'advertly'; -const DOMAIN = 'http://api.advertly.com/'; +const DOMAIN = 'https://api.advertly.com/'; const RENDERER_URL = '//acdn.adnxs.com/video/outstream/ANOutstreamVideo.js'; function isBidRequestValid(bid) { From 908a4e770ac990a099aa186338b29758bb004701 Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Thu, 26 Dec 2019 12:26:59 +0530 Subject: [PATCH 38/40] updated advertly --- test/spec/modules/advertlyBidAdapter_spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/spec/modules/advertlyBidAdapter_spec.js b/test/spec/modules/advertlyBidAdapter_spec.js index 0226884fc01..8705a254377 100755 --- a/test/spec/modules/advertlyBidAdapter_spec.js +++ b/test/spec/modules/advertlyBidAdapter_spec.js @@ -1,7 +1,7 @@ import { expect } from 'chai'; import { spec } from 'modules/advertlyBidAdapter'; -const ENDPOINT = 'http://api.advertly.com/www/admin/plugins/Prebid/getAd.php'; +const ENDPOINT = 'https://api.advertly.com/www/admin/plugins/Prebid/getAd.php'; describe('The Advertly bidding adapter', function () { describe('isBidRequestValid', function () { From 55fc245f923b54969cb0bb56179329067d039b97 Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Thu, 26 Dec 2019 14:29:45 +0530 Subject: [PATCH 39/40] update advertly --- modules/advertlyBidAdapter.js | 1 + 1 file changed, 1 insertion(+) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index 00690a70b0a..7ac0c72f6cd 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -125,3 +125,4 @@ export const spec = { }; registerBidder(spec); + From 8fe4a8568cf2eeb0993a031b50dc18457b83725a Mon Sep 17 00:00:00 2001 From: Advertly <55785260+Advertly@users.noreply.github.com> Date: Thu, 26 Dec 2019 14:32:25 +0530 Subject: [PATCH 40/40] update advertly --- modules/advertlyBidAdapter.js | 1 - 1 file changed, 1 deletion(-) diff --git a/modules/advertlyBidAdapter.js b/modules/advertlyBidAdapter.js index 7ac0c72f6cd..00690a70b0a 100755 --- a/modules/advertlyBidAdapter.js +++ b/modules/advertlyBidAdapter.js @@ -125,4 +125,3 @@ export const spec = { }; registerBidder(spec); -