enable no-console eslint rule for project #4802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
reviewed
Feb 10, 2020
| @@ -81,7 +81,7 @@ describe('onetag', function () { | |||
| } | |||
| }); | |||
| } catch (e) { | |||
| console.log('Error while parsing'); | |||
| console.log('onetagBidAdapter tests: Error while parsing'); // eslint-disable-line | |||
There was a problem hiding this comment.
any reason to keep these these?
There was a problem hiding this comment.
I thought at first they would be good to keep for the adapter's tests, but in retrospect they're not too helpful. I pushed an update to remove them.
snapwich
requested changes
Feb 19, 2020
There was a problem hiding this comment.
I love this idea, but I feel like this should apply to the whole codebase, not just the tests. It's almost more important that console.logs don't end up in src and modules files than in the tests.
Do you think it would be doable to enable this for the project and then add exceptions for the usages in utils.js?
|
Hi @snapwich Expanding the scope does make sense, I'll try to make the necessary updates soon. |
|
I pushed in the requested updates. Please take another look when you get the chance. Thanks! |
1 task
jsnellbaker
changed the title
|
Hey @snapwich @mkendall07 , can you please take another look and approve (if it looks good now)? Thanks! |
jsnellbaker
added
needs 2nd review
redaguermas
added a commit
to redaguermas/Prebid.js
that referenced
this pull request
Mar 13, 2020
* 'master' of https://github.com/prebid/Prebid.js: (49 commits) Submitting Clicktripz bid adapter (prebid#4929) add UNICORN bid adapter (prebid#4917) 3.12.0-pre 3.11.0 release Eids liveintent ext fix (prebid#4944) add mediaforce bid adapter (prebid#4933) update logic in adpod module for playersize (prebid#4953) Module - Size Mapping V2 (prebid#4690) Lifestreet adapter 3.0 (prebid#4927) IX Adapter - Increase banner TTL to 300s (prebid#4957) assert string returned not that we break things (prebid#4962) added option to url parser to ignore decoding entire url (prebid#4938) adding user-id support in medianet adapter (prebid#4925) removing the log (prebid#4960) add import extensions (prebid#4959) Add 7xbid adapter to compatible with prebid 3.0 (prebid#4908) Fix failing code-coverage command (prebid#4892) enable no-console eslint rule for project (prebid#4802) update audigent tests to fix larger test suite issue (prebid#4952) use bidId or bidIds in the payload (prebid#4903) ...
redaguermas
added a commit
to redaguermas/Prebid.js
that referenced
this pull request
Mar 13, 2020
* master: (49 commits) Submitting Clicktripz bid adapter (prebid#4929) add UNICORN bid adapter (prebid#4917) 3.12.0-pre 3.11.0 release Eids liveintent ext fix (prebid#4944) add mediaforce bid adapter (prebid#4933) update logic in adpod module for playersize (prebid#4953) Module - Size Mapping V2 (prebid#4690) Lifestreet adapter 3.0 (prebid#4927) IX Adapter - Increase banner TTL to 300s (prebid#4957) assert string returned not that we break things (prebid#4962) added option to url parser to ignore decoding entire url (prebid#4938) adding user-id support in medianet adapter (prebid#4925) removing the log (prebid#4960) add import extensions (prebid#4959) Add 7xbid adapter to compatible with prebid 3.0 (prebid#4908) Fix failing code-coverage command (prebid#4892) enable no-console eslint rule for project (prebid#4802) update audigent tests to fix larger test suite issue (prebid#4952) use bidId or bidIds in the payload (prebid#4903) ...
rjvelicaria
pushed a commit
to openx/Prebid.js
that referenced
this pull request
Apr 9, 2020
* add no-console eslint rule for tests directory * remove console logs from onetag tests * update scope of rule to include src files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
There have been a number of PRs in the past where the unit tests included some rogue
console.logstatements and they were accidentally missed by the reviewers.While not a big deal, it does end up polluting the console messages when we run the tests (especially the browserstack tests, since they get displayed for each browser), and it becomes somewhat tedious to track them down later and create another PR just to remove them.
I made this PR to enable the no-console rule for the eslint rules in our
testdirectory to hopefully help us better catch these instances during the review process.I also updated the various files in the
testdirectory usingconsole.log; either removing them or disabling the rule.Update
Per feedback, I have extended this lint logic to the project rather than just the tests directory.