use all requestIds #4818
Closed
use all requestIds #4818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumit116
suggested changes
Feb 6, 2020
There was a problem hiding this comment.
Hi @vincentproxistore, I found that the circle-ci build for this PR is run with your account instead of the prebid organisation account and hence its failing. This can be because you may be following your own project rather than the Prebid open source project. I think you need to unfollow the project under your account in CircleCI and instead follow the "real" project and raise a new PR in order to get the circle ci tests passed.
For more details please see #4740 (comment).
|
Closing in lieu of #4849 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
I was only using the id of the first resquest...
Be sure to test the integration with your adserver using the Hello World sample page.