From 01c0e8f9e186697c6723b834478520a4a343eb3e Mon Sep 17 00:00:00 2001 From: Patrick McCann Date: Fri, 19 Jun 2020 12:10:30 -0400 Subject: [PATCH 1/6] add adomain to bid.meta in spotx adapter this puts the adomain key in the right spot, related to https://github.com/prebid/Prebid.js/pull/5358 and partially solves https://github.com/prebid/Prebid.js/issues/3115 for SpotX --- modules/spotxBidAdapter.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/modules/spotxBidAdapter.js b/modules/spotxBidAdapter.js index 1733a176eba..a2f3906fd05 100644 --- a/modules/spotxBidAdapter.js +++ b/modules/spotxBidAdapter.js @@ -330,6 +330,11 @@ export const spec = { width: spotxBid.w, height: spotxBid.h }; + + bid.meta = bid.meta || {}; + if (response && response.adomain && response.adomain.length > 0) { + bid.meta.advertiserDomains = str.split(response.adomain); + } const context1 = utils.deepAccess(currentBidRequest, 'mediaTypes.video.context'); const context2 = utils.deepAccess(currentBidRequest, 'params.ad_unit'); From f655c49b74ec0da117a71b5bcbbf95eeb75e6773 Mon Sep 17 00:00:00 2001 From: Patrick McCann Date: Fri, 19 Jun 2020 12:22:08 -0400 Subject: [PATCH 2/6] Update spotxBidAdapter.js --- modules/spotxBidAdapter.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/spotxBidAdapter.js b/modules/spotxBidAdapter.js index a2f3906fd05..1a72c7992cb 100644 --- a/modules/spotxBidAdapter.js +++ b/modules/spotxBidAdapter.js @@ -330,10 +330,10 @@ export const spec = { width: spotxBid.w, height: spotxBid.h }; - + bid.meta = bid.meta || {}; - if (response && response.adomain && response.adomain.length > 0) { - bid.meta.advertiserDomains = str.split(response.adomain); + if (spotxBid && spotxBid.adomain && spotxBid.adomain.length > 0) { + bid.meta.advertiserDomains = spotxBid.adomain.split(); } const context1 = utils.deepAccess(currentBidRequest, 'mediaTypes.video.context'); From 575d6a942eb938408da0dcc64738a04f832a46cc Mon Sep 17 00:00:00 2001 From: Patrick McCann Date: Fri, 19 Jun 2020 12:51:10 -0400 Subject: [PATCH 3/6] Update spotxBidAdapter.js --- modules/spotxBidAdapter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/spotxBidAdapter.js b/modules/spotxBidAdapter.js index 1a72c7992cb..a8d874c57e9 100644 --- a/modules/spotxBidAdapter.js +++ b/modules/spotxBidAdapter.js @@ -333,7 +333,7 @@ export const spec = { bid.meta = bid.meta || {}; if (spotxBid && spotxBid.adomain && spotxBid.adomain.length > 0) { - bid.meta.advertiserDomains = spotxBid.adomain.split(); + bid.meta.advertiserDomains = spotxBid.adomain; } const context1 = utils.deepAccess(currentBidRequest, 'mediaTypes.video.context'); From 62928f9b94fc65c2b2197d33bbe8b443dba1f087 Mon Sep 17 00:00:00 2001 From: Patrick McCann Date: Tue, 23 Jun 2020 08:58:02 -0400 Subject: [PATCH 4/6] unit test for adomain on spotx adapter --- test/spec/modules/spotxBidAdapter_spec.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/spec/modules/spotxBidAdapter_spec.js b/test/spec/modules/spotxBidAdapter_spec.js index 78d17f35c69..8f6098778e9 100644 --- a/test/spec/modules/spotxBidAdapter_spec.js +++ b/test/spec/modules/spotxBidAdapter_spec.js @@ -381,6 +381,7 @@ describe('the spotx adapter', function () { impid: 123, cur: 'USD', price: 12, + adomain: ['abc.com'], crid: 321, w: 400, h: 300, @@ -392,6 +393,7 @@ describe('the spotx adapter', function () { impid: 124, cur: 'USD', price: 13, + adomain: ['def.com'], w: 200, h: 100, ext: { @@ -409,6 +411,7 @@ describe('the spotx adapter', function () { expect(responses).to.be.an('array').with.length(2); expect(responses[0].cache_key).to.equal('cache123'); expect(responses[0].channel_id).to.equal(12345); + expect(responses[0].adomain).to.equal(['abc.com']); expect(responses[0].cpm).to.equal(12); expect(responses[0].creativeId).to.equal(321); expect(responses[0].currency).to.equal('USD'); @@ -423,6 +426,7 @@ describe('the spotx adapter', function () { expect(responses[1].cache_key).to.equal('cache124'); expect(responses[1].channel_id).to.equal(12345); expect(responses[1].cpm).to.equal(13); + expect(responses[1].adomain).to.equal(['def.com']); expect(responses[1].creativeId).to.equal(''); expect(responses[1].currency).to.equal('USD'); expect(responses[1].height).to.equal(100); From fc78a7d6aa24d866f5afd51b79753ec24047799a Mon Sep 17 00:00:00 2001 From: Patrick McCann Date: Tue, 23 Jun 2020 09:13:04 -0400 Subject: [PATCH 5/6] Update spotxBidAdapter_spec.js --- test/spec/modules/spotxBidAdapter_spec.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/spec/modules/spotxBidAdapter_spec.js b/test/spec/modules/spotxBidAdapter_spec.js index 8f6098778e9..6a43110e49b 100644 --- a/test/spec/modules/spotxBidAdapter_spec.js +++ b/test/spec/modules/spotxBidAdapter_spec.js @@ -411,7 +411,7 @@ describe('the spotx adapter', function () { expect(responses).to.be.an('array').with.length(2); expect(responses[0].cache_key).to.equal('cache123'); expect(responses[0].channel_id).to.equal(12345); - expect(responses[0].adomain).to.equal(['abc.com']); + expect(responses[0].adomain[0]).to.equal('abc.com'); expect(responses[0].cpm).to.equal(12); expect(responses[0].creativeId).to.equal(321); expect(responses[0].currency).to.equal('USD'); @@ -426,7 +426,7 @@ describe('the spotx adapter', function () { expect(responses[1].cache_key).to.equal('cache124'); expect(responses[1].channel_id).to.equal(12345); expect(responses[1].cpm).to.equal(13); - expect(responses[1].adomain).to.equal(['def.com']); + expect(responses[1].adomain[0]).to.equal('def.com'); expect(responses[1].creativeId).to.equal(''); expect(responses[1].currency).to.equal('USD'); expect(responses[1].height).to.equal(100); From c6c2bd2fd7f8bc304ba1a1d4e0b94a12bc0d62bd Mon Sep 17 00:00:00 2001 From: Patrick McCann Date: Tue, 23 Jun 2020 09:53:09 -0400 Subject: [PATCH 6/6] Update spotxBidAdapter_spec.js --- test/spec/modules/spotxBidAdapter_spec.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/spec/modules/spotxBidAdapter_spec.js b/test/spec/modules/spotxBidAdapter_spec.js index 6a43110e49b..94cc335fd8e 100644 --- a/test/spec/modules/spotxBidAdapter_spec.js +++ b/test/spec/modules/spotxBidAdapter_spec.js @@ -411,7 +411,7 @@ describe('the spotx adapter', function () { expect(responses).to.be.an('array').with.length(2); expect(responses[0].cache_key).to.equal('cache123'); expect(responses[0].channel_id).to.equal(12345); - expect(responses[0].adomain[0]).to.equal('abc.com'); + expect(responses[0].meta.advertiserDomains[0]).to.equal('abc.com'); expect(responses[0].cpm).to.equal(12); expect(responses[0].creativeId).to.equal(321); expect(responses[0].currency).to.equal('USD'); @@ -426,7 +426,7 @@ describe('the spotx adapter', function () { expect(responses[1].cache_key).to.equal('cache124'); expect(responses[1].channel_id).to.equal(12345); expect(responses[1].cpm).to.equal(13); - expect(responses[1].adomain[0]).to.equal('def.com'); + expect(responses[1].meta.advertiserDomains[0]).to.equal('def.com'); expect(responses[1].creativeId).to.equal(''); expect(responses[1].currency).to.equal('USD'); expect(responses[1].height).to.equal(100);