From ea4d11541b3c9c5595b22a44ad30ae605df5f80a Mon Sep 17 00:00:00 2001 From: Scott Menzer Date: Sat, 27 Jun 2020 00:33:35 +0200 Subject: [PATCH 1/4] drop support for userId configs with the `usersync` config object, per deprecation notice --- modules/userId/index.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/userId/index.js b/modules/userId/index.js index 88a0a636caf..43c8d4e84b1 100644 --- a/modules/userId/index.js +++ b/modules/userId/index.js @@ -570,8 +570,8 @@ export function init(config) { } // listen for config userSyncs to be set config.getConfig(conf => { - // Note: support for both 'userSync' and 'usersync' will be deprecated with Prebid.js 3.0 - const userSync = conf.userSync || conf.usersync; + // Note: support for 'usersync' was dropped as part of Prebid.js 4.0 + const userSync = conf.userSync; if (userSync && userSync.userIds) { configRegistry = userSync.userIds; syncDelay = utils.isNumber(userSync.syncDelay) ? userSync.syncDelay : DEFAULT_SYNC_DELAY; From bc3eb76a2844b9e106698fe41b89cd53ff26ccf8 Mon Sep 17 00:00:00 2001 From: Patrick McCann Date: Fri, 17 Jul 2020 14:11:19 -0400 Subject: [PATCH 2/4] changes on drop support (#1) * Update userIdTargeting.md * Update userId.md * Update userId_spec.js --- modules/userId/userId.md | 4 ++-- modules/userIdTargeting.md | 2 +- test/spec/modules/userId_spec.js | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/modules/userId/userId.md b/modules/userId/userId.md index eb9e985a1d6..b4ebdf6ff5e 100644 --- a/modules/userId/userId.md +++ b/modules/userId/userId.md @@ -79,7 +79,7 @@ pbjs.setConfig({ Example showing `localStorage` for user id data for some submodules ``` pbjs.setConfig({ - usersync: { + userSync: { userIds: [{ name: "unifiedId", params: { @@ -137,7 +137,7 @@ pbjs.setConfig({ Example showing how to configure a `value` object to pass directly to bid adapters ``` pbjs.setConfig({ - usersync: { + userSync: { userIds: [{ name: "pubCommonId", value: { diff --git a/modules/userIdTargeting.md b/modules/userIdTargeting.md index f99fd5308b3..340c1b6abf2 100644 --- a/modules/userIdTargeting.md +++ b/modules/userIdTargeting.md @@ -8,7 +8,7 @@ pbjs.setConfig({ // your existing userIds config - usersync: { + userSync: { userIds: [{...}, ...] }, diff --git a/test/spec/modules/userId_spec.js b/test/spec/modules/userId_spec.js index 8ce81ea85b0..08ec8e773d9 100644 --- a/test/spec/modules/userId_spec.js +++ b/test/spec/modules/userId_spec.js @@ -655,7 +655,7 @@ describe('User ID', function() { it('does not delay auction if there are no ids to fetch', function() { coreStorage.getCookie.withArgs('MOCKID').returns('123456778'); config.setConfig({ - usersync: { + userSync: { auctionDelay: 33, syncDelay: 77, userIds: [{ From 9d2b7e6b4ba1fa08f23301264fafd2081ce8b1ea Mon Sep 17 00:00:00 2001 From: Patrick McCann Date: Mon, 20 Jul 2020 14:32:50 -0400 Subject: [PATCH 3/4] Update britepoolIdSystem.md --- modules/britepoolIdSystem.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/britepoolIdSystem.md b/modules/britepoolIdSystem.md index 89287aed7ca..a15f601aee3 100644 --- a/modules/britepoolIdSystem.md +++ b/modules/britepoolIdSystem.md @@ -7,7 +7,7 @@ BritePool User ID Module. For assistance setting up your module please contact u Individual params may be set for the BritePool User ID Submodule. At least one identifier must be set in the params. ``` pbjs.setConfig({ - usersync: { + userSync: { userIds: [{ name: 'britepoolId', storage: { From eb070fe8aca5ebbc65a99f42fcfa3fb9c2ade9db Mon Sep 17 00:00:00 2001 From: Patrick McCann Date: Mon, 20 Jul 2020 14:34:40 -0400 Subject: [PATCH 4/4] Update sharedIdSystem.md --- modules/sharedIdSystem.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/sharedIdSystem.md b/modules/sharedIdSystem.md index acb076ed97f..a4541c16c49 100644 --- a/modules/sharedIdSystem.md +++ b/modules/sharedIdSystem.md @@ -13,7 +13,7 @@ ex: $ gulp build --modules=userId,sharedIdSystem Individual params may be set for the Shared ID User ID Submodule. ``` pbjs.setConfig({ - usersync: { + userSync: { userIds: [{ name: 'sharedId', params: {