-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new boldwin bid adapter #5454
new boldwin bid adapter #5454
Conversation
can you copy bid.clickurl domain to bid.meta.advertiserDomains and any other applicable meta domains? see #3115 and http://prebid.org/dev-docs/bidder-adaptor.html#interpreting-the-response |
@patmmccann I've added meta with advert domains |
@patmmccann Good day to you, is there any updates? If thecase in failing circle ci - the problem in another adapter |
I'm not the assigned reviewer; we just have buyer transparency as an initiative that widespread support for meta.AD is the first step of. |
@mike-chowla Good day to you, is everything fine? Can you, please, close review |
@jaiminpanchal27 Good day to you, can i please ask you to assignee another reviewer to close this PR, because current seems have no activity since 14 of july |
I'll look at it today
…On Wed, Jul 22, 2020 at 12:35 AM Adprime ***@***.***> wrote:
@jaiminpanchal27 <https://github.com/jaiminpanchal27> Good day to you,
can i please ask you to assignee another reviewer to close this PR, because
current seems have no activity since 14 of july
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5454 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADF463VK3CIBQ4XDF3RBHITR42JDNANCNFSM4OPXVHAQ>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change
Be sure to test the integration with your adserver using the Hello World sample page.
wls_demo_box@smartyads.com
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
new boldwin bid adapter prebid.github.io#2112
Other information