Onetag update #5503
Merged
Onetag update #5503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f1b0ede
|
Link to the docs PR: |
musikele
suggested changes
Jul 22, 2020
modules/onetagBidAdapter.js
Outdated
| } | ||
| const payloadString = JSON.stringify(payload); | ||
| try { | ||
| if (window.localStorage) { |
There was a problem hiding this comment.
Prebid offers a storageManager class to deal with localStorage or cookies. check out, for example, bidder widespaceBidAdapter (https://github.com/prebid/Prebid.js/blob/master/modules/widespaceBidAdapter.js#L9) and how they use it.
There was a problem hiding this comment.
Hello @musikele , we just pushed the requested changes. Hope you have time enough to review them before your holidays :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fixes some bugs. Adds field 'version' to requests.