Saambaa Bidder Adapter #5526
Saambaa Bidder Adapter #5526
Conversation
update prebid.js code base from fork
LunaMedia Adapater
update code base
Accept size parameters
Adding a new line. home/circleci/Prebid.js/modules/lunamediaBidAdapter.js 401:22 error Newline required at end of file but not found eol-last ✖ 1 problem (1 error, 0 warnings) 1 error, 0 warnings potentially fixable with the `--fix` option.
updated as per review
Update latest changes
Saambaa Bidder Adapter
|
Hi, Can you please let me know what is wrong with adapter. |
| return requests; | ||
| }, | ||
|
|
||
| interpretResponse(serverResponse, {bidRequest}) { |
There was a problem hiding this comment.
it appears from your tests your server responds with adomain. Can you set meta.advertiserDomains ?
There was a problem hiding this comment.
Hi @patmmccann I see all checks have passed, is this change still needed.
There was a problem hiding this comment.
yes, as of prebid 4.0, if you are passing adomain in responses from your endpoint you should be setting it in meta. See the four adapter changes on prebid 4.0 release notes for examples.
There was a problem hiding this comment.
#4824 has the 4.x changes
There was a problem hiding this comment.
Hi @patmmccann let me know if changes are good to merge.
There was a problem hiding this comment.
LGTM
can you resolve comment made by @patmmccann?
Also, can you update description of this pull request and please open PR on docs repo:
https://github.com/prebid/prebid.github.io
|
@FilipStamenkovic here is the doc, thanks for reminding. |
Updating adomain in meta
resolving an error.
Updates related to adomain
There was a problem hiding this comment.
Looks good, just update your docs PR: prebid/prebid.github.io#2159
Is your bidder supporting tcf 1 and/or tcf 2?
I see from this PR that you are passing gdprApplies and consent string.
If you are supporting tcf then add:
gdpr_supported: true
tcf2_supported: true #if you support tcf v2
|
Hi @FilipStamenkovic We currently do not operate in EU and not supporting tcf as well. Let me know if all good and when i can make this adapter available for client. |
Type of change
Description of change
Saambaa Bidder Adapter
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information