Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PR_REVIEW.md for #5237 video params on ad unit #5536

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Update PR_REVIEW.md for #5237 video params on ad unit #5536

merged 1 commit into from
Jul 27, 2020

Conversation

patmmccann
Copy link
Collaborator

@patmmccann patmmccann commented Jul 23, 2020 •
edited
Loading

solves for #5237

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

@patmmccann
Copy link
Collaborator Author

docs pr prebid/prebid.github.io#2158

@patmmccann
Copy link
Collaborator Author

fyi @mike-chowla @ehoch

@jsnellbaker jsnellbaker requested a review from mike-chowla July 27, 2020 13:29
mike-chowla
mike-chowla approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-chowla mike-chowla merged commit 93e1b93 into prebid:master Jul 27, 2020
@patmmccann patmmccann mentioned this pull request Apr 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-chowla mike-chowla mike-chowla approved these changes

Assignees

@mike-chowla mike-chowla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patmmccann @mike-chowla @jsnellbaker