Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for userId_example.html #5606

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Fix for userId_example.html #5606

merged 2 commits into from
Sep 9, 2020

Conversation

shikhar-dev-proj
Copy link
Contributor

@shikhar-dev-proj shikhar-dev-proj commented Aug 14, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

On running gulp serve and navigating to integrationExamples/gpt/userId_example.html?pbjs_debug=true, one can see prebid initialised but the bids are not generated.

Issue arises due to:-

  1. no mediaTypes configuration in adUnit (test-div).
  2. usersync instead of userSync present in setConfig method.
    Fixes of these both are available in this pr and results in correct behaviour in terms of userIds in pbjs.getUserIds() and bids in pbjs.adUnits.

Find the attached console output which shows the error
Screenshot 2020-08-14 at 2 54 17 PM
.

@shikhar-dev-proj
Copy link
Contributor Author

Hi @jlukas79, can we merge this pr?
Please let me know if anything required at my end.

Copy link
Collaborator

@smenzer smenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smenzer
Copy link
Collaborator

smenzer commented Sep 9, 2020

this example page is now broken because it relies on tcf 1 which is no longer supported by the IAB, so the vendorlist.json is failing to load. this is a problem with the other examples, too, though, so that should be corrected separately. i'll go ahead and merge this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants