update quantcastBidAdapter to pass quantcast fpa in the bid request #5947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mckurt
commented
Nov 9, 2020
modules/lunamediahbBidAdapter.js
Outdated
| @@ -70,7 +70,6 @@ export const spec = { | |||
| schain: bid.schain || {}, | |||
| }; | |||
| const mediaType = bid.mediaTypes | |||
|
|
|||
There was a problem hiding this comment.
Build was complaining about this line, so I removed it:
"/home/circleci/Prebid.js/modules/lunamediahbBidAdapter.js
73:1 error Trailing spaces not allowed no-trailing-spaces"
|
@robertrmartinez Thanks for the review. When can we merge this PR? |
modules/quantcastBidAdapter.js
Outdated
| @@ -18,6 +19,9 @@ export const QUANTCAST_TEST_PUBLISHER = 'test-publisher'; | |||
| export const QUANTCAST_TTL = 4; | |||
| export const QUANTCAST_PROTOCOL = 'https'; | |||
| export const QUANTCAST_PORT = '8443'; | |||
| export const QUANTCAST_FPA = '__qca'; | |||
|
|
|||
| export const storage = getStorageManager(); | |||
There was a problem hiding this comment.
Does Quantcast have a registered GVL id?
Passing the following will allow storage access when GDPR Enforcement is enabled.
https://github.com/prebid/Prebid.js/blob/master/modules/appnexusBidAdapter.js#L61
There was a problem hiding this comment.
We do. I updated the code accordingly. Thanks for the catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR updates Quantcast bidding adapter to read the Quantcast first party cookie and include it in the bid request. Please contact asig@quantcast.com for any issues.