Prebidmanager analytics adapter: fix console error when utm is null and collect page info #6002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harpere
requested changes
Nov 20, 2020
| @@ -83,7 +83,7 @@ function collectUtmTagData() { | |||
| if (newUtm === false) { | |||
| utmTags.forEach(function (utmKey) { | |||
| let itemValue = localStorage.getItem(`pm_${utmKey}`); | |||
| if (itemValue.length !== 0) { | |||
| if (itemValue !== null && typeof itemValue !== 'undefined' && itemValue.length !== 0) { | |||
There was a problem hiding this comment.
very minor but simpler to just if (itemValue && itemValue.length !== 0) {
There was a problem hiding this comment.
edited this line. thank you.
| pageInfo.referrerDomain = utils.parseUrl(document.referrer).hostname; | ||
| } | ||
| return pageInfo; | ||
| } |
There was a problem hiding this comment.
would be nice to add a unit test for this.
There was a problem hiding this comment.
added a test in test/spec/modules/prebidmanagerAnalyticsAdapter_spec.js
harpere
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
fix console error when utm data in local storage is null
prebid.js:3 Prebid ERROR: Prebid Manager Analytics: Error TypeError: Cannot read property 'length' of null
add collecting of page info (domain & referrer)