Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fabrick to eids file #6022

Merged
merged 4 commits into from
Dec 1, 2020
Merged

Add fabrick to eids file #6022

merged 4 commits into from
Dec 1, 2020

Conversation

andersonbd1
Copy link
Collaborator

Type of change

@jdwieland8282
Copy link
Member

could you do something simpler like "neustar.com"

@andersonbd1
Copy link
Collaborator Author

@jdwieland8282 - updated to "neustar.biz"

Copy link
Member

@jdwieland8282 jdwieland8282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smenzer
Copy link
Collaborator

smenzer commented Nov 23, 2020

I'd suggest you update the eids.md file as well

@bretg bretg changed the title 6021 Add fabrick to eids file Nov 24, 2020
@pm-harshad-mane
Copy link
Contributor

Hello @andersonbd1 , Could you please update eids.md as well?

@pm-harshad-mane
Copy link
Contributor

Hello @andersonbd1
Gentle reminder to update the eids.md file so that we can merge the PR.

@andersonbd1
Copy link
Collaborator Author

@smenzer , @pm-harshad-mane - update made to eids.md.

Copy link
Collaborator

@smenzer smenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smenzer smenzer merged commit 804d76c into prebid:master Dec 1, 2020
stsepelin pushed a commit to cointraffic/Prebid.js that referenced this pull request May 28, 2021
* Add entry of fabrickId in Eids prebid#6021

* Add entry of fabrickId in Eids prebid#6021

* Add entry of fabrickId in Eids prebid#6021

* Add entry of fabrickId in Eids prebid#6021

Co-authored-by: Anderson, Ben <Ben.Anderson@team.neustar>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants