adagioBidAdapter: add Video support #6038

osazos · 2020-11-26T15:13:33Z

Type of change

Feature
Code style update (formatting, local variables)

Description of change

Add support for Video request in AdagioBidAdapter.

Contact email of the adapter’s maintainer: dev@adagio.io

Related PR (doc): prebid/prebid.github.io#2536

musikele · 2020-12-03T09:54:46Z

Hi @osazos !
Are there any test params to display a fake video? Can you write those test parameters in adagioBidAdapter.md ?

musikele

just one minor modification.

musikele · 2020-12-03T09:55:33Z

modules/adagioBidAdapter.md

@@ -38,6 +47,10 @@ Connects to Adagio demand source to fetch bids.
            category: 'sport', // Recommended. Category of the content displayed in the page.
            subcategory: 'handball', // Optional. Subcategory of the content displayed in the page.
            postBid: false // Optional. Use it in case of Post-bid integration only.


missing a , after postBid: false - discovered while copy/pasting to test the adapter.

osazos · 2020-12-03T14:51:46Z

Hello @musikele

Thanks for your review.

I updated the adagioBidAdapter.md file. As you'll see I set two adUnits regarding their mediaTypes and add the special param key debug which allow you to get a fake response (video or banner) from our SSP.
With this extra param, you can simply use the values set in the examples.

Let me know if you need something else.

musikele

I couldn't make it to work. I see the network response from the bidder with the demo ad, but I don't see the video rendered. I'm going to paste the demo page I tried:

<!--
  This page calls a single bidder for a single ad slot. It can be considered a "hello world" example for using
  Prebid with the Google Publisher Tag.
  It also makes a good test page for new adapter PR submissions. Simply set your server's Bid Params object in the
  bids array inside the adUnits, and it will use your adapter to load an ad.
  NOTE that many ad servers won't send back an ad if the URL is localhost... so you might need to
  set an alias in your /etc/hosts file so that you can load this page from a different domain.
-->

<html>
  <head>
    <script async src="../../build/dev/prebid.js"></script>
    <script
      async
      src="https://www.googletagservices.com/tag/js/gpt.js"
    ></script>
    <script>
      var pbjs = pbjs || {};
      pbjs.que = pbjs.que || [];

      var googletag = googletag || {};
      googletag.cmd = googletag.cmd || [];

      var PREBID_TIMEOUT = 1000;

      var adUnits = [
        {
          code: "video1",
          mediaTypes: {
            video: {
              context: "outstream",
              playerSize: [640, 480],
              mimes: ["video/mp4"],
              //skip: 0,
              // Other OpenRTB 2.5 video options…
            },
          },
          bids: [
            {
              bidder: "adagio", // Required
              params: {
                organizationId: "1002", // Required - Organization ID provided by Adagio.
                site: "adagio-io", // Required - Site Name provided by Adagio.
                placement: "in_article", // Required. Refers to the placement of an adunit in a page. Must not contain any information about the type of device. Other example: `mpu_btf'.
                adUnitElementId: "article_outstream", // Required - AdUnit element id. Refers to the adunit id in a page. Usually equals to the adunit code above.

                // The following params are limited to 30 characters,
                // and can only contain the following characters:
                // - alphanumeric (A-Z+a-z+0-9, case-insensitive)
                // - dashes `-`
                // - underscores `_`
                // Also, each param can have at most 50 unique active values (case-insensitive).
                pagetype: "article", // Highly recommended. The pagetype describes what kind of content will be present in the page.
                environment: "mobile", // Recommended. Environment where the page is displayed.
                category: "sport", // Recommended. Category of the content displayed in the page.
                //subcategory: "handball", // Optional. Subcategory of the content displayed in the page.
                //postBid: false, // Optional. Use it in case of Post-bid integration only.
                // video: {
                //   skip: 0,
                //   // OpenRTB 2.5 video options defined here override ones defined in mediaTypes.
                // },
                // Optional debug mode, used to get a bid response with expected cpm.
                debug: {
                  enabled: true,
                  cpm: 3.0, // default to 1.00
                },
              },
            },
          ],
        },
      ];

      pbjs.que.push(function () {
        pbjs.addAdUnits(adUnits);
        pbjs.bidderSettings = {
          adagio: {
            alwaysUseBid: true,
            adserverTargeting: [
              {
                key: "site",
                val: function (bidResponse) {
                  return bidResponse.site;
                },
              },
              {
                key: "environment",
                val: function (bidResponse) {
                  return bidResponse.environment;
                },
              },
              {
                key: "placement",
                val: function (bidResponse) {
                  return bidResponse.placement;
                },
              },
              {
                key: "pagetype",
                val: function (bidResponse) {
                  return bidResponse.pagetype;
                },
              },
              {
                key: "category",
                val: function (bidResponse) {
                  return bidResponse.category;
                },
              },
              {
                key: "subcategory",
                val: function (bidResponse) {
                  return bidResponse.subcategory;
                },
              },
            ],
          },
        };
        pbjs.requestBids({
          bidsBackHandler: initAdserver,
        });
      });

      function initAdserver() {
        if (pbjs.initAdserverSet) return;
        pbjs.initAdserverSet = true;
        googletag.cmd.push(function () {
          pbjs.que.push(function () {
            pbjs.setTargetingForGPTAsync();
            googletag.pubads().refresh();
          });
        });
      }

      setTimeout(function () {
        initAdserver();
      }, PREBID_TIMEOUT);

      googletag.cmd.push(function () {
        var slot1 = googletag
          .defineSlot("/19968336/prebid_outstream_adunit_1", [[1, 1]], "video1")
          .addService(googletag.pubads());
        googletag.pubads().disableInitialLoad();
        googletag.pubads().enableSingleRequest();
        googletag.enableServices();
      });
    </script>
  </head>

  <body>
    <h2>Prebid.js Test</h2>
    <h5>Div-1</h5>

    <div id="video1">
      <p>Prebid Outstream Video Ad</p>

      <script type="text/javascript">
        googletag.cmd.push(function () {
          googletag.display("video1");
        });
      </script>
    </div>
  </body>
</html>

So, there are two things we can do.

I prefer that we would still try to make the demo ad show up on my pc so we can both be extra safe of what we're merging. You may replicate this setup on your pc with chrome and tell me what's wrong.
If you see it working on your side, and you think the problem I am having is based on some misconfiguration on my side, we can merge this. But I would use this as a last resort. We still have some time before next release.

Let me know how to proceed.

musikele · 2020-12-03T17:26:59Z

modules/adagioBidAdapter.md

+        code: 'article_outstream',
+        mediaTypes: {
+          video: {
+            outstream: {


this outstream: { is not needed. The correct format should be:

{ code: "video1", mediaTypes: { video: { context: "outstream", playerSize: [640, 480], ... } } } ```

Thank you, it works fine!
If you want to update the adagioBidAdapter.md file and fix the example (by removing the outstream: { line (and the corresponding } ) we can merge this one.

Hi @musikele

I amended the adagioBidAdapter.md, so you can merge when you want :)

osazos · 2020-12-04T08:26:13Z

Thanks to take the time to fully test our PR.

I think the issue is due to the default Google slot creative template and some error in the test page.

To see the renderer playing, please update the test page with the code bellow:

var adUnits = [
  {
    code: "video1",
    bids: [
    {
      bidder: "adagio",
      params: {
        organizationId: "1002",
        site: "adagio-io",
        placement: "in_article",
        adUnitElementId: "video1", // --> important for our renderer
        …
    }]
  }
];

function initAdserver(bidResponses) {
  if (pbjs.initAdserverSet) return;
  pbjs.initAdserverSet = true;
  googletag.cmd.push(function () {
    pbjs.que.push(function () {
      pbjs.setTargetingForGPTAsync('video1'); // Required to match the adUnit defined with googletag.defineSlot(), see bellow.
      console.log('bidResponses', bidResponses) // inspect the full bid response object
      googletag.pubads().refresh();
    });
  });
}

…
// Define a slot which can serve a prebid-universal-creative template.
var slot1 = googletag
  .defineSlot("/21686208299/pave", [[1, 1]], "video1")
  .addService(googletag.pubads());

musikele

LGTM

* adagioBidAdapter: add outstream video support * Lint: semi rule consistency * IE11 support: remove Array.includes() * Generate bidResponse.vastUrl based on vastXml dataUri encoding * Update .md file

osazos added 2 commits November 26, 2020 16:08

adagioBidAdapter: add outstream video support

992ec2e

Lint: semi rule consistency

05ada4f

osazos mentioned this pull request Nov 26, 2020

Adagio: add video support prebid/prebid.github.io#2536

Merged

osazos force-pushed the adagio-feature/outstream-video branch from 0a4c752 to a43dbef Compare November 27, 2020 09:48

osazos added 2 commits November 27, 2020 17:41

IE11 support: remove Array.includes()

054f138

Generate bidResponse.vastUrl based on vastXml dataUri encoding

012c647

osazos force-pushed the adagio-feature/outstream-video branch from a43dbef to 012c647 Compare November 27, 2020 16:42

jsnellbaker requested a review from musikele December 1, 2020 13:22

jsnellbaker assigned musikele Dec 1, 2020

jsnellbaker added the needs review label Dec 1, 2020

musikele suggested changes Dec 3, 2020

View reviewed changes

musikele reviewed Dec 3, 2020

View reviewed changes

Update .md file

6fc58c1

osazos force-pushed the adagio-feature/outstream-video branch from 721e62a to 6fc58c1 Compare December 4, 2020 08:29

musikele approved these changes Dec 4, 2020

View reviewed changes

musikele merged commit 2b730a8 into prebid:master Dec 4, 2020

osazos mentioned this pull request Dec 8, 2020

Adagio Bid Adapter: hotfix - detect support for intersectionObserver #6095

Merged

2 tasks

osazos deleted the adagio-feature/outstream-video branch March 15, 2021 08:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adagioBidAdapter: add Video support #6038

adagioBidAdapter: add Video support #6038

osazos commented Nov 26, 2020

musikele commented Dec 3, 2020

musikele left a comment

musikele Dec 3, 2020

osazos commented Dec 3, 2020 •

edited

Loading

musikele left a comment •

edited

Loading

musikele Dec 3, 2020

musikele Dec 4, 2020

osazos Dec 4, 2020

osazos commented Dec 4, 2020

musikele left a comment

adagioBidAdapter: add Video support #6038

adagioBidAdapter: add Video support #6038

Conversation

osazos commented Nov 26, 2020

Type of change

Description of change

musikele commented Dec 3, 2020

musikele left a comment

Choose a reason for hiding this comment

musikele Dec 3, 2020

Choose a reason for hiding this comment

osazos commented Dec 3, 2020 • edited Loading

musikele left a comment • edited Loading

Choose a reason for hiding this comment

musikele Dec 3, 2020

Choose a reason for hiding this comment

musikele Dec 4, 2020

Choose a reason for hiding this comment

osazos Dec 4, 2020

Choose a reason for hiding this comment

osazos commented Dec 4, 2020

musikele left a comment

Choose a reason for hiding this comment

osazos commented Dec 3, 2020 •

edited

Loading

musikele left a comment •

edited

Loading