Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ttl value #6041

Merged
merged 4 commits into from
Dec 2, 2020
Merged

update ttl value #6041

merged 4 commits into from
Dec 2, 2020

Conversation

steve-a-districtm
Copy link
Contributor

@steve-a-districtm steve-a-districtm commented Nov 27, 2020

Type of change

  • [ x] Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

TTL value was too short for video caching

allow users to be sent to dmx even when gdpr is configured in prebid
Change default ttl value for banner and video
@Rothalack
Copy link
Collaborator

Not sure why Circleci failed on the previous run, but it ran just fine that time.

This looks good to go, very straight forward.

Copy link
Collaborator

@Rothalack Rothalack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Rothalack Rothalack merged commit 03ed221 into prebid:master Dec 2, 2020
stsepelin pushed a commit to cointraffic/Prebid.js that referenced this pull request May 28, 2021
* allow users to be sent to dmx even when gdpr is configured in prebid

* Change default ttl value

Change default ttl value for banner and video

Co-authored-by: Menelik Tucker <menelik@districtm.net>
Co-authored-by: Tucker <72400387+MenelikTucker-districtm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants