From c204a5cb30ed9db80da5c126fecdf380ef6dbdbc Mon Sep 17 00:00:00 2001 From: Stephen Johnston Date: Fri, 4 Dec 2020 09:09:31 -0500 Subject: [PATCH 1/2] Add Release Drafter Instructions to PR_REVIEW.md --- PR_REVIEW.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PR_REVIEW.md b/PR_REVIEW.md index f991a0254f5..4ea8fd8fb6d 100644 --- a/PR_REVIEW.md +++ b/PR_REVIEW.md @@ -18,7 +18,10 @@ For modules and core platform updates, the initial reviewer should request an ad - If the change results in needing updates to docs (such as public API change, module interface etc), add a label for "needs docs" and inform the submitter they must submit a docs PR to update the appropriate area of Prebid.org **before the PR can merge**. Help them with finding where the docs are located on prebid.org if needed. - If all above is good, add a `LGTM` comment and, if the change is in PBS-core or is an important module like the prebidServerBidAdapter, request 1 additional core member to review. - Once there are 2 `LGTM` on the PR, merge to master -- Add a line into the [draft release](https://github.com/prebid/Prebid.js/releases) notes for this submission. If no draft release is available, create one using [this template]( https://gist.github.com/mkendall07/c3af6f4691bed8a46738b3675cb5a479) +- The [draft release](https://github.com/prebid/Prebid.js/releases) notes are managed by [release drafter](https://github.com/release-drafter/release-drafter). To get the PR added to the release notes do the steps below. A github action will use that information to build the release notes. + - Adjust the PR Title to be appropriate for release notes + - Add a label for feature, maintenance, fix, bugfix or bug to categorize the PR + - Add a semver label of major, minor or patch to indicate the scope of change ### Reviewing a New or Updated Bid Adapter Documentation they're supposed to be following is https://docs.prebid.org/dev-docs/bidder-adaptor.html From 35bea23e4a2e193c755beb7344a69da42ed5798e Mon Sep 17 00:00:00 2001 From: Stephen Johnston Date: Sat, 5 Dec 2020 19:03:03 -0500 Subject: [PATCH 2/2] Add Prettier Formatting Makes keywords more distinct. Co-authored-by: Scott Menzer --- PR_REVIEW.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PR_REVIEW.md b/PR_REVIEW.md index 4ea8fd8fb6d..662a1a871c8 100644 --- a/PR_REVIEW.md +++ b/PR_REVIEW.md @@ -20,8 +20,8 @@ For modules and core platform updates, the initial reviewer should request an ad - Once there are 2 `LGTM` on the PR, merge to master - The [draft release](https://github.com/prebid/Prebid.js/releases) notes are managed by [release drafter](https://github.com/release-drafter/release-drafter). To get the PR added to the release notes do the steps below. A github action will use that information to build the release notes. - Adjust the PR Title to be appropriate for release notes - - Add a label for feature, maintenance, fix, bugfix or bug to categorize the PR - - Add a semver label of major, minor or patch to indicate the scope of change + - Add a label for `feature`, `maintenance`, `fix`, `bugfix` or `bug` to categorize the PR + - Add a semver label of `major`, `minor` or `patch` to indicate the scope of change ### Reviewing a New or Updated Bid Adapter Documentation they're supposed to be following is https://docs.prebid.org/dev-docs/bidder-adaptor.html