From eb06348118e82a34c161089aacbb5fc32b534eb1 Mon Sep 17 00:00:00 2001 From: Victor Date: Tue, 2 Feb 2021 17:15:18 +0100 Subject: [PATCH 1/3] Add prebid version to data object --- modules/parrableIdSystem.js | 3 ++- test/spec/modules/parrableIdSystem_spec.js | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/modules/parrableIdSystem.js b/modules/parrableIdSystem.js index 7587962c62b..7558ad0686c 100644 --- a/modules/parrableIdSystem.js +++ b/modules/parrableIdSystem.js @@ -178,7 +178,8 @@ function fetchId(configParams) { const data = { eid, trackers: configParams.partner.split(','), - url: refererInfo.referer + url: refererInfo.referer, + prebid: '$prebid.version$' }; const searchParams = { diff --git a/test/spec/modules/parrableIdSystem_spec.js b/test/spec/modules/parrableIdSystem_spec.js index 5e62af9b2fa..55cd4b6bd5a 100644 --- a/test/spec/modules/parrableIdSystem_spec.js +++ b/test/spec/modules/parrableIdSystem_spec.js @@ -74,7 +74,7 @@ function removeParrableCookie() { storage.setCookie(P_COOKIE_NAME, '', EXPIRED_COOKIE_DATE); } -describe('Parrable ID System', function() { +describe.only('Parrable ID System', function() { describe('parrableIdSystem.getId()', function() { describe('response callback function', function() { let logErrorStub; @@ -107,7 +107,8 @@ describe('Parrable ID System', function() { expect(data).to.deep.equal({ eid: P_COOKIE_EID, trackers: P_CONFIG_MOCK.params.partner.split(','), - url: getRefererInfo().referer + url: getRefererInfo().referer, + prebid: '$prebid.version$', }); server.requests[0].respond(200, From 4b3164f1f39e68ac3807d498def9d772780ad54f Mon Sep 17 00:00:00 2001 From: Victor Date: Tue, 2 Feb 2021 18:02:28 +0100 Subject: [PATCH 2/3] Renamed prebid to prebidVersion --- modules/parrableIdSystem.js | 2 +- test/spec/modules/parrableIdSystem_spec.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/parrableIdSystem.js b/modules/parrableIdSystem.js index 7558ad0686c..6f0078d296d 100644 --- a/modules/parrableIdSystem.js +++ b/modules/parrableIdSystem.js @@ -179,7 +179,7 @@ function fetchId(configParams) { eid, trackers: configParams.partner.split(','), url: refererInfo.referer, - prebid: '$prebid.version$' + prebidVersion: '$prebid.version$' }; const searchParams = { diff --git a/test/spec/modules/parrableIdSystem_spec.js b/test/spec/modules/parrableIdSystem_spec.js index 55cd4b6bd5a..b88d2f87a51 100644 --- a/test/spec/modules/parrableIdSystem_spec.js +++ b/test/spec/modules/parrableIdSystem_spec.js @@ -74,7 +74,7 @@ function removeParrableCookie() { storage.setCookie(P_COOKIE_NAME, '', EXPIRED_COOKIE_DATE); } -describe.only('Parrable ID System', function() { +describe('Parrable ID System', function() { describe('parrableIdSystem.getId()', function() { describe('response callback function', function() { let logErrorStub; @@ -108,7 +108,7 @@ describe.only('Parrable ID System', function() { eid: P_COOKIE_EID, trackers: P_CONFIG_MOCK.params.partner.split(','), url: getRefererInfo().referer, - prebid: '$prebid.version$', + prebidVersion: '$prebid.version$', }); server.requests[0].respond(200, From 950e7a13e29136bb6d2b136eaed167ff3f51c9ab Mon Sep 17 00:00:00 2001 From: victorigualada Date: Fri, 5 Feb 2021 14:21:25 +0100 Subject: [PATCH 3/3] Fix missing coma --- modules/parrableIdSystem.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/parrableIdSystem.js b/modules/parrableIdSystem.js index b45ede25b9e..237708aec57 100644 --- a/modules/parrableIdSystem.js +++ b/modules/parrableIdSystem.js @@ -188,8 +188,8 @@ function fetchId(configParams) { eid, trackers: configParams.partner.split(','), url: refererInfo.referer, - prebidVersion: '$prebid.version$' - isIframe: utils.inIframe(), + prebidVersion: '$prebid.version$', + isIframe: utils.inIframe() }; const searchParams = {