Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBjs Core: override refererInfo.canonicalUrl if pageUrl is defined in config #6591

Merged
merged 2 commits into from
Apr 21, 2021

Conversation

mmoschovas
Copy link
Contributor

Type of change

  • Bugfix
  • [X ] Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Updated refererDetection logic for canonical url.

  1. Run getConfig('pageUrl')
    • If value exists, return config set value
      • If undefined, run standard logic to retrieve canonical url from link tag
  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ChrisHuie ChrisHuie changed the title Override refererInfo.canonicalUrl if pageUrl is defined in config PBjs Core: override refererInfo.canonicalUrl if pageUrl is defined in config Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants