Interactive Offers Bid Adapter: added data to the final response object #6648

IOTiagoFaria · 2021-04-23T16:15:13Z

Type of change

Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other

Description of change

test parameters for validating bids

{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

contact email of the adapter’s maintainer
official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

* adds meta field to bidresponse * adds meta mediatype and advertiserdomain default * use response sizes in bidresponse

* Magnite renderer support for Oustream ads * add functions for hiding ad units * Add unit tests * adding open source location of renderer * better minification Co-authored-by: bretg <bgorsline@gmail.com>

ChrisHuie · 2021-04-24T10:46:33Z

@IOTiagoFaria it appears you are overwriting your entire current bid adapter file? I haven't compared the two files but is this intentional?

Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com>

IOTiagoFaria · 2021-04-26T08:36:51Z

@ChrisHuie The only changes where made to the "parseResponseOpenRTBToPrebidjs" function.
Not sure why it shows as a new file

* RTD Provider rebase * wrongly merged to master * Added meta field for advertiser domains.

* Add files via upload * Add files via upload * Change params on gnetBidder * ADJ - Use parseSizesInput to get sizes ADJ - Check serverResponse object ADJ - Remove getUserSyncs function * ADJ - Change prebid endpoint * ADJ - Change endpoint on test

* Added TheMediaGridNM Bid Adapter * Updated required params for TheMediaGridNM Bid Adapter * Update TheMediGridNM Bid Adapter * Fix tests for TheMediaGridNM Bid Adapter * Fixes after review for TheMediaGridNM Bid Adapter * Add support of multi-format in TheMediaGrid Bid Adapter * Update sync url for grid and gridNM Bid Adapters * TheMediaGrid Bid Adapter: added keywords adUnit parameter * Update TheMediaGrid Bid Adapter to support keywords from config * Implement new request format for TheMediaGrid Bid Adapter * Fix jwpseg params for TheMediaGrid Bid Adapter * Update unit tests for The Media Grid Bid Adapter * Fix typo in TheMediaGrid Bid Adapter * Added test for jwTargeting in TheMediaGrid Bid Adapter * The new request format was made by default in TheMediaGrid Bid Adapter * Update userId format in ad request for TheMediaGrid Bid Adapter * Added bidFloor parameter for TheMediaGrid Bid Adapter * Fix for review TheMediaGrid Bid Adapter * Support floorModule in TheMediaGrid Bid Adapter * Fix empty bidfloor for TheMediaGrid Bid Adapter * Some change to restart autotests * Fix userIds format for TheMediaGrid Bid Adapter * Remove digitrust userId from TheMediaGrid Bid Adapter * Protocols was added in video section in ad request for TheMediaGrid Bid Adapter * TheMediaGrid: fix trouble with alias using * TheMediaGridNM: fix trouble with alias * TheMediaGrid Bid Adapter: added support of PBAdSlot module * TheMediaGrid Bid Adapter: fix typo

* Sonobi - Added Coppa Flag check * added unit test for sonobi coppa flag

* update gothamAds adapter * update GothamAdsAdapter according to commetns. Add meta for adomains

patmmccann · 2021-04-27T12:34:01Z

Includes change for #6466 thank you

…dd support for meta.advertiserDomains (#6656) * Update eids.js * Update eids_spec.js * Update eids.js * Update pubmaticBidAdapter_spec.js * Update eids.js * Update eids_spec.js * Update conversantBidAdapter_spec.js * Update rubiconBidAdapter_spec.js * Update conversantBidAdapter_spec.js * Delete test/spec/adapters directory * Update userId_spec.js * Delete iasBidAdapter.js * Add files via upload * Update deepintentBidAdapter.js * Update deepintentBidAdapter_spec.js * Update rtbhouseBidAdapter.js * Update rtbhouseBidAdapter_spec.js * Update deepintentBidAdapter.js * Update rtbhouseBidAdapter.js * Update rtbhouseBidAdapter.js * Update rtbhouseBidAdapter_spec.js * Update deepintentBidAdapter.js * Update rhythmoneBidAdapter.js * Update rhythmoneBidAdapter_spec.js * Update aolBidAdapter.js * Update aolBidAdapter_spec.js * Update aolBidAdapter.js * Update aolBidAdapter.js * Update teadsBidAdapter.js * Update teadsBidAdapter_spec.js * Update openxBidAdapter_spec.js * Update openxBidAdapter.js * Update openxBidAdapter.js * Update openxBidAdapter_spec.js * Update openxBidAdapter.js

IOTiagoFaria · 2021-04-27T14:17:37Z

@patmmccann are these the changes you requested? e1d7aa9

* RTD Provider rebase * wrongly merged to master * Added meta field for advertiser domains. * Fixing bug where losing bids throw undefined into the response. * Wrapped if-statement

ChrisHuie · 2021-04-27T18:51:21Z

@IOTiagoFaria can you please pull in recent merges so this pr doesn't view all these changes as new added files 🙏 Not sure what happened but hoping that fixes the git additions to sync

patmmccann · 2021-04-27T18:56:56Z

@patmmccann are these the changes you requested? e1d7aa9

Thanks for adding advertiserDomains, you have been removed from the list of bidders who do not support adomain.

IOTiagoFaria · 2021-04-30T10:05:14Z

@ChrisHuie what is the status of this review?

patmmccann · 2021-04-30T10:38:07Z

@ChrisHuie what is the status of this review?

You have 37 files changed in this PR.

It's important to only submit your changes.

IOTiagoFaria · 2021-04-30T10:53:56Z

My mistake, do you think it will be easier/faster if this PR got cancelled and I create a new one with the fork fully updated?

patmmccann · 2021-04-30T10:58:28Z

That's up to you; it's no trouble if you want to close and resubmit or prefer to fix this one

…nse object" This reverts commit fdac148.

IOTiagoFaria · 2021-04-30T11:27:00Z

I think its better for a new PR to be created, I don't want to mess this one even more...

IOTiagoFaria · 2021-04-30T11:57:37Z

new PR created #6680

IOTiagoFaria and others added 13 commits March 9, 2021 12:26

Interactive Offers bid adapter

2a780e8

Interactive Offers bid adapter

f5c631a

Interactive Offers bid adapter

f90d4ba

Interactive Offers bid adapter

cc950c8

Interactive Offers bid adapter

2721b56

Interactive Offers bid adapter

a7d11e3

Interactive Offers bid adapter

908a3c9

Interactive Offers bid adapter

54100b0

manually kicking off tests

ced2ced

Interactive Offers Bid Adapter: added data to the final response object

fdac148

GumGum Bid Adapter: use ad response sizes when found (#6649)

d3c7731

* adds meta field to bidresponse * adds meta mediatype and advertiserdomain default * use response sizes in bidresponse

Rubicon Bid Adapter: add outstream rendering (#6469)

6c0142a

* Magnite renderer support for Oustream ads * add functions for hiding ad units * Add unit tests * adding open source location of renderer * better minification Co-authored-by: bretg <bgorsline@gmail.com>

Halo RTD submodule: update docs (#6651)

15c31c8

patmmccann added maintenance minor labels Apr 24, 2021

ChrisHuie self-requested a review April 24, 2021 10:46

ChrisHuie self-assigned this Apr 24, 2021

sid into tags for ZetaSsp (#6636)

722afa1

Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com>

dreischer and others added 5 commits April 26, 2021 08:26

Add module name to storage manager; catch errors (#6596)

4d842d2

Adnuntius Bid Adatpter: Meta field advertiser domain update. (#6652)

c408a6e

* RTD Provider rebase * wrongly merged to master * Added meta field for advertiser domains.

Sonobi Bid Adapter: added Coppa Flag check (#6631)

d6a2ed7

* Sonobi - Added Coppa Flag check * added unit test for sonobi coppa flag

harpere added the needs review label Apr 27, 2021

supportGothamad and others added 3 commits April 27, 2021 05:05

GothamAds Bid Adapter: add at, ccpa, gdpr and coppa support (#6470)

f3624eb

* update gothamAds adapter * update GothamAdsAdapter according to commetns. Add meta for adomains

Rubicon Bid Adapter: Added new size - Id 558 (640x640) (#6658)

cef4c89

Interactive Offers Bid Adapter: change maintainer email

1ac2e5f

patmmccann and others added 2 commits April 27, 2021 05:48

Interactive Offers Bid Adapter: add meta.advertiserDomains to response

e1d7aa9

Adnuntius Bid Adapter: bugfix to set undefined if no bids (#6662)

1f04682

* RTD Provider rebase * wrongly merged to master * Added meta field for advertiser domains. * Fixing bug where losing bids throw undefined into the response. * Wrapped if-statement

pass auctionId (#6664)

71d75c4

IOTiagoFaria and others added 4 commits April 27, 2021 15:38

Interactive Offers bid adapter

d04db3a

Interactive Offers bid adapter

49808e0

Interactive Offers bid adapter

87bcb74

Merge branch 'master' of https://github.com/IOTiagoFaria/Prebid.js

b987dcc

Revert "Interactive Offers Bid Adapter: added data to the final respo…

6690b2f

…nse object" This reverts commit fdac148.

IOTiagoFaria closed this Apr 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Interactive Offers Bid Adapter: added data to the final response object #6648

Interactive Offers Bid Adapter: added data to the final response object #6648

IOTiagoFaria commented Apr 23, 2021 •

edited

Loading

ChrisHuie commented Apr 24, 2021

IOTiagoFaria commented Apr 26, 2021

patmmccann commented Apr 27, 2021

IOTiagoFaria commented Apr 27, 2021 •

edited

Loading

ChrisHuie commented Apr 27, 2021

patmmccann commented Apr 27, 2021

IOTiagoFaria commented Apr 30, 2021

patmmccann commented Apr 30, 2021

IOTiagoFaria commented Apr 30, 2021

patmmccann commented Apr 30, 2021

IOTiagoFaria commented Apr 30, 2021

IOTiagoFaria commented Apr 30, 2021

Interactive Offers Bid Adapter: added data to the final response object #6648

Interactive Offers Bid Adapter: added data to the final response object #6648

Conversation

IOTiagoFaria commented Apr 23, 2021 • edited Loading

Type of change

Description of change

Other information

ChrisHuie commented Apr 24, 2021

IOTiagoFaria commented Apr 26, 2021

patmmccann commented Apr 27, 2021

IOTiagoFaria commented Apr 27, 2021 • edited Loading

ChrisHuie commented Apr 27, 2021

patmmccann commented Apr 27, 2021

IOTiagoFaria commented Apr 30, 2021

patmmccann commented Apr 30, 2021

IOTiagoFaria commented Apr 30, 2021

patmmccann commented Apr 30, 2021

IOTiagoFaria commented Apr 30, 2021

IOTiagoFaria commented Apr 30, 2021

IOTiagoFaria commented Apr 23, 2021 •

edited

Loading

IOTiagoFaria commented Apr 27, 2021 •

edited

Loading