From fb3ccd3d16d2298364a8d6c6f2e8d9ec770d2b9b Mon Sep 17 00:00:00 2001 From: Myles Wehr Date: Mon, 3 May 2021 16:07:47 -0400 Subject: [PATCH 1/4] adapter updates --- modules/zetaBidAdapter.js | 9 ++++----- modules/zetaBidAdapter.md | 2 +- test/spec/modules/zetaBidAdapter_spec.js | 4 ++-- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/modules/zetaBidAdapter.js b/modules/zetaBidAdapter.js index b168bf581d0..908b2b76a26 100644 --- a/modules/zetaBidAdapter.js +++ b/modules/zetaBidAdapter.js @@ -2,7 +2,7 @@ import * as utils from '../src/utils.js'; import { registerBidder } from '../src/adapters/bidderFactory.js'; import {BANNER} from '../src/mediaTypes.js'; const BIDDER_CODE = 'zeta_global'; -const ENDPOINT_URL = 'https://prebid.rfihub.com/prebid'; +const ENDPOINT_URL = 'http://ewr-337.rfiserve.net:2082/prebid'; const USER_SYNC_URL = 'https://p.rfihub.com/cm?pub=42770&in=1'; const DEFAULT_CUR = 'USD'; const TTL = 200; @@ -87,9 +87,7 @@ export const spec = { badv: params.badv, bapp: params.bapp, source: params.source ? params.source : {}, - ext: { - definerId: params.definerId - } + ext: params.ext ? params.ext : {} }; payload.device.ua = navigator.userAgent; @@ -113,9 +111,10 @@ export const spec = { } }; } + const postUrl = ENDPOINT_URL.concat(params.definerId !== '0' ? params.definerId : ''); return { method: 'POST', - url: ENDPOINT_URL, + url: postUrl, data: JSON.stringify(payload), }; }, diff --git a/modules/zetaBidAdapter.md b/modules/zetaBidAdapter.md index d99846c7822..2646e829823 100644 --- a/modules/zetaBidAdapter.md +++ b/modules/zetaBidAdapter.md @@ -35,7 +35,7 @@ Module that connects to Zeta's demand sources country: "USA" } }, - definerId: 1, + definerId: 42770, test: 1 } } diff --git a/test/spec/modules/zetaBidAdapter_spec.js b/test/spec/modules/zetaBidAdapter_spec.js index b3380ab35db..ccdd5f43cb0 100644 --- a/test/spec/modules/zetaBidAdapter_spec.js +++ b/test/spec/modules/zetaBidAdapter_spec.js @@ -10,7 +10,7 @@ describe('Zeta Bid Adapter', function() { } }, refererInfo: { - referer: 'zetaglobal.com' + referer: 'testprebid.com' }, params: { placement: 12345, @@ -24,7 +24,7 @@ describe('Zeta Bid Adapter', function() { country: 'USA' } }, - definerId: 1, + definerId: '0', test: 1 } }]; From 540e80f2520d080a71ed3156233a1bcff72c9169 Mon Sep 17 00:00:00 2001 From: Myles Wehr Date: Mon, 3 May 2021 16:10:10 -0400 Subject: [PATCH 2/4] remove testing changes --- modules/zetaBidAdapter.js | 2 +- modules/zetaBidAdapter.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/zetaBidAdapter.js b/modules/zetaBidAdapter.js index 908b2b76a26..f4924472248 100644 --- a/modules/zetaBidAdapter.js +++ b/modules/zetaBidAdapter.js @@ -2,7 +2,7 @@ import * as utils from '../src/utils.js'; import { registerBidder } from '../src/adapters/bidderFactory.js'; import {BANNER} from '../src/mediaTypes.js'; const BIDDER_CODE = 'zeta_global'; -const ENDPOINT_URL = 'http://ewr-337.rfiserve.net:2082/prebid'; +const ENDPOINT_URL = 'https://prebid.rfihub.com/prebid'; const USER_SYNC_URL = 'https://p.rfihub.com/cm?pub=42770&in=1'; const DEFAULT_CUR = 'USD'; const TTL = 200; diff --git a/modules/zetaBidAdapter.md b/modules/zetaBidAdapter.md index 2646e829823..9702aaf2808 100644 --- a/modules/zetaBidAdapter.md +++ b/modules/zetaBidAdapter.md @@ -35,7 +35,7 @@ Module that connects to Zeta's demand sources country: "USA" } }, - definerId: 42770, + definerId: 0, test: 1 } } From 2968f8e4d5d4167e4c4b4eff7197f79051b4f8c3 Mon Sep 17 00:00:00 2001 From: Myles Wehr Date: Tue, 4 May 2021 17:39:25 -0400 Subject: [PATCH 3/4] modify endpoint path --- modules/zetaBidAdapter.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/zetaBidAdapter.js b/modules/zetaBidAdapter.js index f4924472248..e7c233b9577 100644 --- a/modules/zetaBidAdapter.js +++ b/modules/zetaBidAdapter.js @@ -93,6 +93,7 @@ export const spec = { payload.device.ua = navigator.userAgent; payload.site.page = bidderRequest.refererInfo.referer; payload.site.mobile = /(ios|ipod|ipad|iphone|android)/i.test(navigator.userAgent) ? 1 : 0; + payload.ext.definerId = params.definerId; if (params.test) { payload.test = params.test; @@ -111,7 +112,7 @@ export const spec = { } }; } - const postUrl = ENDPOINT_URL.concat(params.definerId !== '0' ? params.definerId : ''); + const postUrl = ENDPOINT_URL.concat(params.definerId !== '0' ? concat("/", params.definerId) : ''); return { method: 'POST', url: postUrl, From f2dcd6d1051b6075a5da321c9601a1760354193c Mon Sep 17 00:00:00 2001 From: Myles Wehr Date: Tue, 4 May 2021 18:08:32 -0400 Subject: [PATCH 4/4] address testing issues --- modules/zetaBidAdapter.js | 2 +- modules/zetaBidAdapter.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/zetaBidAdapter.js b/modules/zetaBidAdapter.js index e7c233b9577..ee5c854df97 100644 --- a/modules/zetaBidAdapter.js +++ b/modules/zetaBidAdapter.js @@ -112,7 +112,7 @@ export const spec = { } }; } - const postUrl = ENDPOINT_URL.concat(params.definerId !== '0' ? concat("/", params.definerId) : ''); + const postUrl = params.definerId !== '0' ? ENDPOINT_URL.concat('/', params.definerId) : ENDPOINT_URL; return { method: 'POST', url: postUrl, diff --git a/modules/zetaBidAdapter.md b/modules/zetaBidAdapter.md index 9702aaf2808..89a9767d29a 100644 --- a/modules/zetaBidAdapter.md +++ b/modules/zetaBidAdapter.md @@ -32,10 +32,10 @@ Module that connects to Zeta's demand sources device: { ip: '111.222.33.44', geo: { - country: "USA" + country: 'USA' } }, - definerId: 0, + definerId: '0', test: 1 } }