Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridNM Bid Adapter: use absent in video params data from mediaTypes #6817

Merged
merged 61 commits into from
Jun 2, 2021

Conversation

TheMediaGrid
Copy link
Contributor

@TheMediaGrid TheMediaGrid commented May 24, 2021

Type of change

  • Bugfix

Description of change

Use absent in params data from mediaTypes

Pull request in doc repository - prebid/prebid.github.io#2984

@ChrisHuie ChrisHuie self-requested a review May 24, 2021 10:13
@ChrisHuie ChrisHuie self-assigned this May 24, 2021
@ChrisHuie ChrisHuie removed their request for review May 24, 2021 11:24
@ChrisHuie ChrisHuie removed their assignment May 24, 2021
@patmmccann
Copy link
Collaborator

This appears to solve #6807

Can you add .MD and docs changes?

@patmmccann patmmccann changed the title GridNM Bid Adapter: use absent in params data from mediaTypes GridNM Bid Adapter: use absent in video params data from mediaTypes May 24, 2021
@patmmccann
Copy link
Collaborator

Please also add support for meta.advertiserDomains around line 170

@TheMediaGrid
Copy link
Contributor Author

There is some minor fixes about netRevenue for grid and gridNM adapters

modules/gridNMBidAdapter.js Show resolved Hide resolved
modules/gridNMBidAdapter.js Outdated Show resolved Hide resolved
modules/gridNMBidAdapter.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ncolletti ncolletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ncolletti ncolletti merged commit 25106da into prebid:master Jun 2, 2021
K-JBoon added a commit to bluebillywig/Prebid.js that referenced this pull request Jun 3, 2021
* 'master' of github.com:prebid/Prebid.js: (303 commits)
  BridgewellBidAdapter: modify to include user ids in the bid request object (prebid#6845)
  GridNMBidAdapter: Use absent in video params data from mediaTypes (prebid#6817)
  PubMatic: For Video: bid.mediaTypes.video.mimes OR bid.params.video.mimes should be present and must be a non-empty array (prebid#6926)
  Increment pre version
  Prebid 4.42.0 Release
  Seedtag Bid Adapter: read video params from mediaTypes, and allow override from bidder params, support passing adomain (prebid#6888)
  Medianet bid adapter: MD update for video parameters. (prebid#6922)
  dgkeyword RTD Provider: add new real time data module  (prebid#6912)
  Smaato bid adapter: Rework multi imp support (prebid#6814)
  Adot Bid Adapter: add the advertising domains support (prebid#6876)
  Update Adtelligent, Adtarget, ViewDeos   adapters to support adomain (prebid#6917)
  LockerDome Bid Adapter: support for meta.advertiserDomains  (prebid#6921)
  Sublime Bid Adapter : Add support for meta.advertiserDomains (prebid#6920)
  Brightcom Bid Adapter: use getFloor function (prebid#6918)
  AdYouLike Bidder: Handle advertiser domains (prebid#6916)
  relaido Bid Adapter: Add meta OBJ to BidResponse (prebid#6914)
  Jixie Bid Adapter: add support for advertiserDomains (prebid#6898)
  Onomagic Bid Adapter: use getFloor function (prebid#6907)
  Sharethrough Bid Adapter: Use getFloor module for Prebid 5.0 compliance (prebid#6874)
  Accept outstream renderers defined in mediatype for PBS (prebid#6896)
  ...
@jsnellbaker jsnellbaker added patch and removed minor labels Jun 3, 2021
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants