ConnectAd Bid-Adapter: Add adomain support #6859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging b85dd8c into f2befaa - view on LGTM.com new alerts:
|
|
can you please add a test to cover with/without |
@ChrisHuie Done! Thanks for reviewing! |
ChrisHuie
approved these changes
Jun 1, 2021
prebidtappx
pushed a commit
to prebidtappx/Prebid.js
that referenced
this pull request
Nov 15, 2021
* ConnectAd bid adapter: Add adomain support Add adomain support * ConnectAd Bid-Adapter: Add adomain support fix * ConnectAd Bid-Adapter: Add adomain support * ConnectAd Bid-Adapter: Add adomain support test update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add meta.advertiserDomains to ConnectAd Bid-Adapter
support@connectad.io