-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oneVideo Bid Adapter: adomain & mediaTypes.video Support (SAPR-16874) #6925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks so much! Does this cover #6650 as well? |
patmmccann
requested changes
Jun 2, 2021
DeepthiNeeladri
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!! we are keeping the linearity param the same rest all we are validating
Hi @patmmccann, |
patmmccann
approved these changes
Jun 3, 2021
patmmccann
changed the title
oneVideo Bid Adapter: mediaTypes.video Support (SAPR-16874)
oneVideo Bid Adapter: adomain & mediaTypes.video Support (SAPR-16874)
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Hi @patmmccann
In alignment with #6807 the oneVideoBidAdapter now listens to bid.mediaTypes.video params first. bid.params.video are used as overrides or in cases where bid.mediaTypes.video params are missing.
This update includes:
This test will only work if you pass bid.params.site.page = "https:verizonmedia.com"
And make the request using VPN location US west coast.
Other information
Hi @DeepthiNeeladri & @kprasadpvv,
Prebid V.5 is supposed to go live on June 9th.
I have created this PR to mitigate removal of the adapter specifically for this version.
Would you be able to review please?
Main changes are in validations and param settings.
Thanks in advance!
Adam