Rule Enforcement: include support for adomain #6986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 1 alert when merging c702558 into 0b55d6b - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 456033b into 0b55d6b - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging b811741 into 0b55d6b - view on LGTM.com fixed alerts:
|
|
This pull request fixes 54 alerts when merging 1fffadf into 0b55d6b - view on LGTM.com fixed alerts:
|
patmmccann
requested changes
Jun 9, 2021
|
This pull request fixes 54 alerts when merging ab5a648 into 0b55d6b - view on LGTM.com fixed alerts:
|
patmmccann
requested changes
Jun 9, 2021
modules/widespaceBidAdapter.js
Outdated
| @@ -61,7 +61,7 @@ export const spec = { | |||
| 'gdprCmp': bidderRequest && bidderRequest.gdprConsent ? 1 : 0, | |||
| 'hb': '1', | |||
| 'hb.cd': CUST_DATA ? encodedParamValue(CUST_DATA) : '', | |||
| 'hb.floor': '', | |||
| 'hb.floor': bid.bidfloor || '', | |||
There was a problem hiding this comment.
i think you got the old widespace.js
patmmccann
approved these changes
Jun 9, 2021
|
This pull request fixes 54 alerts when merging ccfa44b into 0b55d6b - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.