Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubient Bid Adapter: add video support, issues fixes, and compliance with v5 #7058

Merged
merged 19 commits into from
Jul 7, 2021

Conversation

alexartwww
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Added fixes for issues:
#6512
#6466
#6465
Added Video support
New PBJS endpoint
Compliant to Prebid v5

Documentation update:
prebid/prebid.github.io#3043

  • test parameters for validating bids
Banner:
var adUnits = [
    {
        code: 'banner-ad-unit',
        mediaTypes: {
            banner: {
                sizes: [[300, 100]]
            }
        },
        bids: [{
            bidder: 'kubient',
            params: {
                zoneid: "5fbb948f1e22b",
            }
        }]
    }
];

Video:
var adUnits = [
    {
        code: 'video-ad-unit',
        mediaTypes: {
            video: {
                playerSize: [300, 250],               // required
                context: 'instream',                  // required
                mimes: ['video/mp4','video/x-flv'],   // required
                protocols: [ 2, 3 ],                  // required, set at least 1 value in array
                placement: 1,                         // optional, defaults to 2 when context = outstream
                api: [ 1, 2 ],                        // optional
                skip: 0,                              // optional
                minduration: 5,                       // optional
                maxduration: 30,                      // optional
                playbackmethod: [1,3],                // optional
                battr: [ 13, 14 ],                    // optional
                linearity: 1,                         // optional
                minbitrate: 10,                       // optional
                maxbitrate: 10                        // optional
            }
        },
        bids: [{
            bidder: 'kubient',
            params: {
                zoneid: "60ad1c0b35864",
            }
        }]
    }
];

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ChrisHuie ChrisHuie changed the title Kubient video Kubient Bid Adapter: add video support, issues fixes, and compliance with v5 Jun 18, 2021
@jsnellbaker jsnellbaker requested a review from ncolletti June 21, 2021 13:29
@alexartwww
Copy link
Contributor Author

@ncolletti could you check CI. I've tested locally - tests are ok. I backmerged upstream. Looks like this errors not connectoed to our code.

Copy link
Contributor

@ncolletti ncolletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ncolletti ncolletti merged commit 797c7ef into prebid:master Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants