-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pixfuture Bid Adapter: updated the getUserSyncs method #7456
Conversation
Bug fixing: has been lost "pubext" parameter
Removing the trailing spaces in lines: 168 and 172
removing trilling spaces in the lines: 168,172,178
@pixfuture-media it looks like your whole files are being commited instead of just the recent changes |
Sorry, we worried lost some changes and replaced all file. |
Hi Chris, Best Regrds, |
@pixfuture-media can you please pull in recent commits? That should fix most of the problem. Also, we just made it so all adapters are now only importing the utils functions they need instead of the whole file. So now you no longer need |
…ils import by separated methods instead whole utils updated the getUserSyncs method and changed utils import by separated methods instead whole utils
Fixed utls import
Bugfixing remove non used fill import
Hello Chris, its look fine everything now/ What do you think? Regards, |
@pixfuture-media were you able to pull in recent commits. There still appear to be conflicts |
Hi Chris, I made pull request again but it look conflict remained. Is it possible to somebody who have an write access fix it? Regards, |
@pixfuture-media I can try and resolve it but I don't have write access to this specific pr so not entirely sure if it will let me update it. |
Hello, |
PR look fine right now? |
* Add files via upload * Add files via upload * Update pixfutureBidAdapter.md * Update pixfutureBidAdapter.md * Update pixfutureBidAdapter.js * Update pixfutureBidAdapter_spec.js * Update pixfutureBidAdapter.js * Update pixfutureBidAdapter.js Bug fixing: has been lost "pubext" parameter * Update pixfutureBidAdapter.js * Update pixfutureBidAdapter.md * Update pixfutureBidAdapter.js * Update pixfutureBidAdapter.js * Update pixfutureBidAdapter.js * Update pixfutureBidAdapter.js Removing the trailing spaces in lines: 168 and 172 * Add files via upload * Update pixfutureBidAdapter.js removing trilling spaces in the lines: 168,172,178 * Update pixfutureBidAdapter.md * Update pixfutureBidAdapter.md * Update pixfutureBidAdapter.js * Update pixfutureBidAdapter.js * Update pixfutureBidAdapter.js * Update pixfutureBidAdapter.js * Pixfuture Bid Adapter: updated the getUserSyncs method and changed utils import by separated methods instead whole utils updated the getUserSyncs method and changed utils import by separated methods instead whole utils * Fixed utls import Fixed utls import * Bugfixing remove non used fill import Bugfixing remove non used fill import * Update pixfutureBidAdapter.js * resolving conflicts * multiline fix Co-authored-by: polischukPix <o.polishchuk@pixfuture.com> Co-authored-by: Alexandr <i.polischukalexandr@gmail.com>
Type of change
Description of change
Updated the getUserSyncs method