From 92905364f911ffa2f51b6abfaa111e4e35c54733 Mon Sep 17 00:00:00 2001 From: matiasnfuentes Date: Fri, 24 Sep 2021 14:29:42 -0300 Subject: [PATCH 1/2] E-planning Bid Adapter hostname modification --- modules/eplanningBidAdapter.js | 2 +- test/spec/modules/eplanningBidAdapter_spec.js | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/modules/eplanningBidAdapter.js b/modules/eplanningBidAdapter.js index dd96353dea3..655ea8e0fcc 100644 --- a/modules/eplanningBidAdapter.js +++ b/modules/eplanningBidAdapter.js @@ -7,7 +7,7 @@ export const storage = getStorageManager(); const BIDDER_CODE = 'eplanning'; const rnd = Math.random(); -const DEFAULT_SV = 'ads.us.e-planning.net'; +const DEFAULT_SV = 'pbjs.e-planning.net'; const DEFAULT_ISV = 'i.e-planning.net'; const PARAMS = ['ci', 'sv', 't', 'ml', 'sn']; const DOLLARS = 'USD'; diff --git a/test/spec/modules/eplanningBidAdapter_spec.js b/test/spec/modules/eplanningBidAdapter_spec.js index 6aa191f29a5..c6104a23a1c 100644 --- a/test/spec/modules/eplanningBidAdapter_spec.js +++ b/test/spec/modules/eplanningBidAdapter_spec.js @@ -350,7 +350,7 @@ describe('E-Planning Adapter', function () { it('should create the url correctly', function () { const url = spec.buildRequests(bidRequests, bidderRequest).url; - expect(url).to.equal('https://ads.us.e-planning.net/pbjs/1/' + CI + '/1/localhost/ROS'); + expect(url).to.equal('https://pbjs.e-planning.net/pbjs/1/' + CI + '/1/localhost/ROS'); }); it('should return GET method', function () { @@ -740,7 +740,7 @@ describe('E-Planning Adapter', function () { hasLocalStorageStub.returns(false); const response = spec.buildRequests(bidRequests, bidderRequest); - expect(response.url).to.equal('https://ads.us.e-planning.net/pbjs/1/' + CI + '/1/localhost/ROS'); + expect(response.url).to.equal('https://pbjs.e-planning.net/pbjs/1/' + CI + '/1/localhost/ROS'); expect(response.data.vs).to.equal('F'); sinon.assert.notCalled(getLocalStorageSpy); @@ -750,7 +750,7 @@ describe('E-Planning Adapter', function () { it('should create the url correctly with LocalStorage', function() { createElementVisible(); const response = spec.buildRequests(bidRequests, bidderRequest); - expect(response.url).to.equal('https://ads.us.e-planning.net/pbjs/1/' + CI + '/1/localhost/ROS'); + expect(response.url).to.equal('https://pbjs.e-planning.net/pbjs/1/' + CI + '/1/localhost/ROS'); expect(response.data.vs).to.equal('F'); From 0e9634f5bd07633c5418e6ea3b24917b2560126a Mon Sep 17 00:00:00 2001 From: matiasnfuentes Date: Fri, 24 Sep 2021 15:28:49 -0300 Subject: [PATCH 2/2] Change of currency constant name in E-planning bid adapter --- modules/eplanningBidAdapter.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/eplanningBidAdapter.js b/modules/eplanningBidAdapter.js index 655ea8e0fcc..a0321410b27 100644 --- a/modules/eplanningBidAdapter.js +++ b/modules/eplanningBidAdapter.js @@ -10,7 +10,7 @@ const rnd = Math.random(); const DEFAULT_SV = 'pbjs.e-planning.net'; const DEFAULT_ISV = 'i.e-planning.net'; const PARAMS = ['ci', 'sv', 't', 'ml', 'sn']; -const DOLLARS = 'USD'; +const DOLLAR_CODE = 'USD'; const NET_REVENUE = true; const TTL = 120; const NULL_SIZE = '1x1'; @@ -115,7 +115,7 @@ export const spec = { ttl: TTL, creativeId: ad.crid, netRevenue: NET_REVENUE, - currency: DOLLARS, + currency: DOLLAR_CODE, }; if (ad.adom) { bidResponse.meta = {