-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yahoo user identity module: initial release #7519
Yahoo user identity module: initial release #7519
Conversation
…ture/yahoo-user-identity-module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
FYI CircleCI test failing due to 3p adapter "SharedId"
@ncolletti - The docs PR is now here: prebid/prebid.github.io#3334 |
Could you also add your module examples to the following files:
|
…ture/yahoo-user-identity-module
@ncolletti - Any chance this PR can be checked again? With regards to the example, isn't the example found in modules/connectIdSystem.md enough? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@slimkrazy It is a small request to add examples to the remaining two markdown files. You also need to add your id module to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change
Description of change
All things with Verizon Media branding are shifting to the Yahoo brand. A new bid adapter is being prepared by @adam-browning and will soon be in PR, but in the meantime here is the newly branded user identity module.
The plan from the team is to first release the new Yahoo bid adapter - this will consume user ID data from the newly branded UserID module, then in a later release we will drop the old 'aol' adapter and add 'aol' as an alias of the new Yahoo bid adapter (config is the same). At this point we will also remove the old Verizon Media user identity module.
Will update this PR shortly once I open a PR for the documentation site.