Browi RTD provider: code improvements #7589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
browsi sub module for real time data, new hook bidsBackCallback, fix for config unsubscribe
configure submodule on submodules.json
browsi sub module for real time data, new hook bidsBackCallback, fix for config unsubscribe
configure submodule on submodules.json
# Conflicts: # modules/browsiRtdProvider.js
# Conflicts: # modules/browsiRtdProvider.js # modules/rtdModule/index.js
|
This pull request introduces 2 alerts when merging c2abb48 into 38b9816 - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging 88fc84f into 38b9816 - view on LGTM.com new alerts:
|
ChrisHuie
changed the title
|
This pull request introduces 2 alerts when merging 303e2b8 into 4dc1a22 - view on LGTM.com new alerts:
|
msm0504
approved these changes
Oct 26, 2021
|
@omerBrowsi did you see the LGTM errors? |
cpabst
pushed a commit
to sovrn/Prebid.js
that referenced
this pull request
Jan 10, 2022
* real time data module, browsi sub module for real time data, new hook bidsBackCallback, fix for config unsubscribe * change timeout&primary ad server only to auctionDelay update docs * support multiple providers * change promise to callbacks configure submodule on submodules.json * bug fixes * use Prebid ajax * tests fix * browsi real time data provider improvements * real time data module, browsi sub module for real time data, new hook bidsBackCallback, fix for config unsubscribe * change timeout&primary ad server only to auctionDelay update docs * support multiple providers * change promise to callbacks configure submodule on submodules.json * bug fixes * use Prebid ajax * tests fix * browsi real time data provider improvements * browsi rtd - refresh predictions & bid request data * Browsi RTD provider improvements * bid request key fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Some code improvements