From b1cc757adeb0705e977cd86f771233fd6027f4f6 Mon Sep 17 00:00:00 2001 From: Wei Wong Date: Tue, 1 Mar 2022 13:22:48 +0100 Subject: [PATCH 1/2] Kargo Bid Adapter: Use currency from Bid Response --- modules/kargoBidAdapter.js | 2 +- test/spec/modules/kargoBidAdapter_spec.js | 25 +++++++++++++++++++++++ 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/modules/kargoBidAdapter.js b/modules/kargoBidAdapter.js index ff56c97e7b7..dc8f200a421 100644 --- a/modules/kargoBidAdapter.js +++ b/modules/kargoBidAdapter.js @@ -87,7 +87,7 @@ export const spec = { creativeId: adUnit.id, dealId: adUnit.targetingCustom, netRevenue: true, - currency: bidRequest.currency, + currency: (adUnit.currency && adUnit.currency) || bidRequest.currency, meta: meta }); } diff --git a/test/spec/modules/kargoBidAdapter_spec.js b/test/spec/modules/kargoBidAdapter_spec.js index 1eb514e87d2..5e5f47f9a07 100644 --- a/test/spec/modules/kargoBidAdapter_spec.js +++ b/test/spec/modules/kargoBidAdapter_spec.js @@ -493,6 +493,15 @@ describe('kargo adapter tests', function () { adm: '
', width: 300, height: 250 + }, + 4: { + id: 'bar', + cpm: 2.5, + adm: '
', + width: 300, + height: 250, + metadata: {}, + currency: 'EUR' } }}, { currency: 'USD', @@ -511,6 +520,11 @@ describe('kargo adapter tests', function () { params: { placementId: 'bar' } + }, { + bidId: 4, + params: { + placementId: 'bar' + } }] }); var expectation = [{ @@ -552,6 +566,17 @@ describe('kargo adapter tests', function () { netRevenue: true, currency: 'USD', meta: undefined + }, { + requestId: '4', + cpm: 2.5, + width: 300, + height: 250, + ad: '
', + creativeId: 'bar', + dealId: undefined, + netRevenue: true, + currency: 'EUR', + meta: undefined }]; expect(resp).to.deep.equal(expectation); }); From 4be60a2619c0794dae47b4689a72a64fc61ece39 Mon Sep 17 00:00:00 2001 From: Wei Wong Date: Wed, 2 Mar 2022 15:02:21 +0100 Subject: [PATCH 2/2] Kargo Bid Adapter: Fix failed test --- test/spec/modules/kargoBidAdapter_spec.js | 1 + 1 file changed, 1 insertion(+) diff --git a/test/spec/modules/kargoBidAdapter_spec.js b/test/spec/modules/kargoBidAdapter_spec.js index 5e5f47f9a07..d3ac8f4020c 100644 --- a/test/spec/modules/kargoBidAdapter_spec.js +++ b/test/spec/modules/kargoBidAdapter_spec.js @@ -572,6 +572,7 @@ describe('kargo adapter tests', function () { width: 300, height: 250, ad: '
', + ttl: 300, creativeId: 'bar', dealId: undefined, netRevenue: true,