Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insticator: add schain, eids, gpid support to version 5 #8195

Merged
merged 3 commits into from
Mar 17, 2022
Merged

Insticator: add schain, eids, gpid support to version 5 #8195

merged 3 commits into from
Mar 17, 2022

Conversation

sderbush-tt
Copy link
Contributor

Type of change

  • Feature

Description of change

Added support schain.
Added support eids.
Added support gpid.

  • test parameters for validating bids
{
   bidder: 'insticator',
   params: {
       adUnitId: 'test'
   }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

@sderbush-tt
Update insticatorBidAdapter.js
4b071bd 
Use find from core-js-pure
@sderbush-tt sderbush-tt requested a review from dgirardi March 17, 2022 15:31
dgirardi
dgirardi approved these changes Mar 17, 2022
View reviewed changes
modules/insticatorBidAdapter.js
@@ -64,17 +66,19 @@ function buildImpression(bidRequest) {
});
}

const gpid = deepAccess(bidRequest, 'ortb2Imp.ext.gpid');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that master does not do this, but I found #8189 which should bring them in sync. LGTM.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8189 has been merged

@dgirardi dgirardi merged commit 51be171 into prebid:5.20.x-legacy Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patmmccann patmmccann patmmccann left review comments

@dgirardi dgirardi dgirardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sderbush-tt @patmmccann @dgirardi