Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZetaGlobalSsp BidAdapter: shortname to url #8471

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
da0b4a5
Merge pull request #1 from prebid/master
asurovenko-zeta Mar 24, 2021
f4ec68e
Merge branch 'master' of git://github.com/prebid/Prebid.js
surovenko Apr 21, 2021
01990a9
Merge remote-tracking branch 'upstream/master'
surovenko May 18, 2021
62f969f
Merge remote-tracking branch 'upstream/master'
surovenko May 18, 2021
ec7c8f0
Merge remote-tracking branch 'upstream/master'
surovenko May 19, 2021
89fe5b1
Merge remote-tracking branch 'upstream/master'
surovenko May 24, 2021
6dc0255
Merge remote-tracking branch 'upstream/master'
surovenko Jun 1, 2021
8dc9ac2
Merge remote-tracking branch 'upstream/master'
surovenko Jun 3, 2021
35353f0
Merge remote-tracking branch 'upstream/master'
surovenko Jun 3, 2021
e6f982a
Merge remote-tracking branch 'upstream/master'
surovenko Jun 4, 2021
70e546c
Merge remote-tracking branch 'upstream/master'
surovenko Jun 7, 2021
cc56875
Merge remote-tracking branch 'upstream/master'
surovenko Jun 15, 2021
f4f2a1e
Merge remote-tracking branch 'upstream/master'
surovenko Jun 16, 2021
3f96c6a
Merge remote-tracking branch 'upstream/master'
surovenko Jul 8, 2021
8e503cd
Merge remote-tracking branch 'upstream/master'
surovenko Aug 3, 2021
1781bfd
Merge remote-tracking branch 'upstream/master'
surovenko Aug 12, 2021
459917b
Merge remote-tracking branch 'upstream/master'
surovenko Aug 17, 2021
9ce50bd
Merge remote-tracking branch 'upstream/master'
surovenko Aug 18, 2021
8f7f147
Merge remote-tracking branch 'upstream/master'
surovenko Aug 19, 2021
a280757
Merge remote-tracking branch 'upstream/master'
surovenko Sep 22, 2021
036d5f1
Merge remote-tracking branch 'upstream/master'
surovenko Nov 19, 2021
33e883f
Merge remote-tracking branch 'upstream/master'
surovenko Nov 26, 2021
e729eb9
Merge remote-tracking branch 'upstream/master'
surovenko Dec 28, 2021
c202e93
Merge remote-tracking branch 'origin/master'
surovenko Feb 17, 2022
95877a7
Merge remote-tracking branch 'upstream/master'
surovenko Feb 22, 2022
bf8f638
Merge remote-tracking branch 'upstream/master'
surovenko Feb 28, 2022
461374f
Merge remote-tracking branch 'upstream/master'
surovenko Mar 5, 2022
b6a2fdc
Merge remote-tracking branch 'upstream/master'
surovenko Mar 9, 2022
92b44e3
Merge remote-tracking branch 'upstream/master'
surovenko May 23, 2022
42381eb
Merge remote-tracking branch 'upstream/master'
surovenko May 25, 2022
7b1b980
ZetaGlobalSsp bid adapter: shortname param into url param
surovenko May 25, 2022
f629f34
Merge remote-tracking branch 'upstream/master'
surovenko May 26, 2022
9627d5d
Merge remote-tracking branch 'upstream/master'
surovenko May 27, 2022
57016ae
Merge branch 'master' into zeta_global_ssp_bid_adapter_shortname_to_url
surovenko May 27, 2022
70327d5
fix tests
surovenko May 27, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions modules/zeta_global_sspBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export const spec = {
user: params.user ? params.user : {},
app: params.app ? params.app : {},
ext: {
tags: {...params.tags, shortname: params.shortname},
tags: params.tags ? params.tags : {},
sid: params.sid ? params.sid : undefined
}
};
Expand All @@ -126,9 +126,10 @@ export const spec = {
}

provideEids(request, payload);
const url = params.shortname ? ENDPOINT_URL.concat('?shortname=', params.shortname) : ENDPOINT_URL;
return {
method: 'POST',
url: ENDPOINT_URL,
url: url,
data: JSON.stringify(payload),
};
},
Expand Down
6 changes: 4 additions & 2 deletions test/spec/modules/zeta_global_sspBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -270,16 +270,18 @@ describe('Zeta Ssp Bid Adapter', function () {
it('Test required params in banner request', function () {
const request = spec.buildRequests(bannerRequest, bannerRequest[0]);
const payload = JSON.parse(request.data);
expect(request.url).to.eql('https://ssp.disqus.com/bid?shortname=test_shortname');
expect(payload.ext.sid).to.eql('publisherId');
expect(payload.ext.tags.someTag).to.eql(444);
expect(payload.ext.tags.shortname).to.eql('test_shortname');
expect(payload.ext.tags.shortname).to.be.undefined;
});

it('Test required params in video request', function () {
const request = spec.buildRequests(videoRequest, videoRequest[0]);
const payload = JSON.parse(request.data);
expect(request.url).to.eql('https://ssp.disqus.com/bid?shortname=test_shortname');
expect(payload.ext.sid).to.eql('publisherId');
expect(payload.ext.tags.someTag).to.eql(444);
expect(payload.ext.tags.shortname).to.eql('test_shortname');
expect(payload.ext.tags.shortname).to.be.undefined;
});
});