Config max request header size #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexBVolcy
reviewed
Apr 23, 2024
|
Looks good. I'm just waiting to see @AlexBVolcy's comments addressed. |
SyntaxNode
reviewed
Apr 25, 2024
config/config.go
Outdated
| @@ -95,6 +95,7 @@ func setConfigDefaults(v *viper.Viper) { | |||
| v.SetDefault("request_limits.max_size_bytes", utils.REQUEST_MAX_SIZE_BYTES) | |||
| v.SetDefault("request_limits.max_num_values", utils.REQUEST_MAX_NUM_VALUES) | |||
| v.SetDefault("request_limits.max_ttl_seconds", utils.REQUEST_MAX_TTL_SECONDS) | |||
| v.SetDefault("request_limits.max_header_size_bytes", 0) | |||
There was a problem hiding this comment.
If zero, the http.Server is created with a the http library's DefaultMaxHeaderBytes constant that equals 1 MB
AlexBVolcy
previously approved these changes
May 1, 2024
bsardo
reviewed
May 1, 2024
config/config_test.go
Outdated
| @@ -867,6 +867,18 @@ func TestRequestLimitsValidateAndLog(t *testing.T) { | |||
| }, | |||
| expectFatal: true, | |||
| }, | |||
| { | |||
| description: "Negative max_num_values, expect fatal level log and early exit", | |||
There was a problem hiding this comment.
Nitpick: this comment should reference max_header_size_bytes instead of max_num_values.
AlexBVolcy
approved these changes
May 6, 2024
bsardo
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #168 by adding a config field to specify the http request max header size in bytes.