Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAXNative adapter hangs and may effectively prevent any other bids from the waterfall to load #874

Closed
kubamatula opened this issue Jun 23, 2023 · 9 comments
Milestone

Comments

@kubamatula
Copy link
Contributor

MAXNative adapter does not use the correct delegate to notify about early failures, which possibly results in no ad being able to load from the waterfall.

#873

@YuriyVelichkoPI YuriyVelichkoPI added this to the 2.1.2 milestone Jun 23, 2023
@YuriyVelichkoPI
Copy link
Contributor

Hi @kubamatula ! Thanks for the debugging and fixes.

Ilooks like it makes sense to release a hotfix version with the changes for the current issue and for the #869.

However, if you are actively working on integration, I would like to wait in case you find more places to fix.

If it makes sense to you, we'll wait for the green lite for the hotfix release from you in GitHub, in any of your tickets, or in Slack.

@kubamatula
Copy link
Contributor Author

@YuriyVelichkoPI native ads seem to be working. If I find anything else - I will report it, but 🟢 for now.

@kubamatula
Copy link
Contributor Author

@YuriyVelichkoPI I would also love to get a Slack invite to https://redditadops.slack.com/

@YuriyVelichkoPI
Copy link
Contributor

I don't aware of this workspace :(

@YuriyVelichkoPI
Copy link
Contributor

@YuriyVelichkoPI native ads seem to be working. If I find anything else - I will report it, but 🟢 for now.

Great! We'll release a new version on Monday if there are no other urgent issues.

@kubamatula
Copy link
Contributor Author

@YuriyVelichkoPI what workspace are You using then? I took that one form: https://docs.prebid.org/support/#ad-ops-slack-channel

@YuriyVelichkoPI
Copy link
Contributor

Hey, @kubamatula! We use the #prebid-mobile channel in the Prebid.org workspace. If you already have access to the workspace - please find us by the channel name. If not, since NewsBreak is a Prebid member, I should be able to add you to the workspace by your corporate email. Please share it here or via email.

@kubamatula
Copy link
Contributor Author

kubamatula commented Jun 26, 2023

@YuriyVelichkoPI My corporate email -**************

@YuriyVelichkoPI
Copy link
Contributor

Hi, @kubamatula looks like I misunderstood your company. Sorry, but only Prebid.org members can be added to Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants