diff --git a/src/main/java/org/prebid/server/bidder/connectad/ConnectAdBidder.java b/src/main/java/org/prebid/server/bidder/connectad/ConnectAdBidder.java index afac2b57f84..4c64992184b 100644 --- a/src/main/java/org/prebid/server/bidder/connectad/ConnectAdBidder.java +++ b/src/main/java/org/prebid/server/bidder/connectad/ConnectAdBidder.java @@ -91,18 +91,18 @@ private ExtImpConnectAd parseImpExt(Imp imp) { } catch (IllegalArgumentException e) { throw new PreBidException("Impression id=%s, has invalid Ext".formatted(imp.getId())); } - final Integer siteId = extImpConnectAd.getSiteId(); - if (siteId == null || siteId == 0) { + final String siteId = extImpConnectAd.getSiteId(); + if (siteId == null) { throw new PreBidException("Impression id=%s, has no siteId present".formatted(imp.getId())); } return extImpConnectAd; } - private Imp updateImp(Imp imp, Integer secure, Integer siteId, BigDecimal bidFloor) { + private Imp updateImp(Imp imp, Integer secure, String siteId, BigDecimal bidFloor) { final boolean isValidBidFloor = BidderUtil.isValidPrice(bidFloor); return imp.toBuilder() .banner(updateBanner(imp.getBanner())) - .tagid(siteId.toString()) + .tagid(siteId) .secure(secure) .bidfloor(isValidBidFloor ? bidFloor : imp.getBidfloor()) .bidfloorcur(isValidBidFloor ? "USD" : imp.getBidfloorcur()) diff --git a/src/main/java/org/prebid/server/proto/openrtb/ext/request/connectad/ExtImpConnectAd.java b/src/main/java/org/prebid/server/proto/openrtb/ext/request/connectad/ExtImpConnectAd.java index fc5f6dc6489..a88bbc2194d 100644 --- a/src/main/java/org/prebid/server/proto/openrtb/ext/request/connectad/ExtImpConnectAd.java +++ b/src/main/java/org/prebid/server/proto/openrtb/ext/request/connectad/ExtImpConnectAd.java @@ -11,10 +11,10 @@ public class ExtImpConnectAd { @JsonProperty("networkId") - Integer networkId; + String networkId; @JsonProperty("siteId") - Integer siteId; + String siteId; @JsonProperty("bidfloor") BigDecimal bidFloor; diff --git a/src/main/resources/bidder-config/lemmadigital.yaml b/src/main/resources/bidder-config/lemmadigital.yaml index 1d7208aff4f..3f71b2d016c 100644 --- a/src/main/resources/bidder-config/lemmadigital.yaml +++ b/src/main/resources/bidder-config/lemmadigital.yaml @@ -1,6 +1,6 @@ adapters: lemmadigital: - endpoint: https://sg.ads.lemmatechnologies.com/lemma/servad?pid={{PublisherID}}&aid={{AdUnit}} + endpoint: https://pbid.lemmamedia.com/lemma/servad?src=prebid&pid={{PublisherID}}&aid={{AdUnit}} meta-info: maintainer-email: support@lemmatechnologies.com endpoint-compression: gzip @@ -13,3 +13,9 @@ adapters: - video supported-vendors: vendor-id: 0 + usersync: + cookie-family-name: lemmadigital + redirect: + url: https://sync.lemmadigital.com/setuid?publisher=850&redirect={{redirect_url}} + support-cors: false + uid-macro: '${UUID}' diff --git a/src/main/resources/bidder-config/playdigo.yaml b/src/main/resources/bidder-config/playdigo.yaml index 2c8706860f8..adb14424c1b 100644 --- a/src/main/resources/bidder-config/playdigo.yaml +++ b/src/main/resources/bidder-config/playdigo.yaml @@ -14,7 +14,7 @@ adapters: - video - native supported-vendors: - vendor-id: 0 + vendor-id: 1302 usersync: cookie-family-name: playdigo redirect: diff --git a/src/main/resources/bidder-config/qt.yaml b/src/main/resources/bidder-config/qt.yaml index 67e006405d3..8c81123c8ca 100644 --- a/src/main/resources/bidder-config/qt.yaml +++ b/src/main/resources/bidder-config/qt.yaml @@ -12,7 +12,7 @@ adapters: - video - native supported-vendors: - vendor-id: 0 + vendor-id: 1331 usersync: cookie-family-name: qt redirect: diff --git a/src/main/resources/bidder-config/smartx.yaml b/src/main/resources/bidder-config/smartx.yaml index 50a731d8c9d..d0f4498a32a 100644 --- a/src/main/resources/bidder-config/smartx.yaml +++ b/src/main/resources/bidder-config/smartx.yaml @@ -1,6 +1,7 @@ adapters: smartx: endpoint: https://bid.smartclip.net/bid/1005 + ortb-version: "2.6" meta-info: maintainer-email: bidding@smartclip.tv app-media-types: diff --git a/src/test/java/org/prebid/server/bidder/connectad/ConnectAdBidderTest.java b/src/test/java/org/prebid/server/bidder/connectad/ConnectAdBidderTest.java index 35e12ad3510..3ac89edc67a 100644 --- a/src/test/java/org/prebid/server/bidder/connectad/ConnectAdBidderTest.java +++ b/src/test/java/org/prebid/server/bidder/connectad/ConnectAdBidderTest.java @@ -146,7 +146,7 @@ public void makeHttpRequestsShouldReturnErrorIfImpExtHasNoSiteId() { impBuilder -> impBuilder .id("123") .ext(mapper.valueToTree(ExtPrebid.of(null, - ExtImpConnectAd.of(12, null, BigDecimal.ONE))))); + ExtImpConnectAd.of("12", null, BigDecimal.ONE))))); // when final Result>> result = target.makeHttpRequests(bidRequest); @@ -164,7 +164,7 @@ public void impSecureShouldBeOneIfSitePageStartsFromHttps() { impBuilder -> impBuilder .id("123") .ext(mapper.valueToTree(ExtPrebid.of(null, - ExtImpConnectAd.of(12, 1, BigDecimal.ONE))))); + ExtImpConnectAd.of("12", "1", BigDecimal.ONE))))); // when final Result>> result = target.makeHttpRequests(bidRequest); @@ -202,7 +202,7 @@ private static Imp givenImp(Function impCustomiz .w(14) .h(15).build()) .ext(mapper.valueToTree(ExtPrebid.of(null, - ExtImpConnectAd.of(12, 12, BigDecimal.ONE))))) + ExtImpConnectAd.of("12", "12", BigDecimal.ONE))))) .build(); } diff --git a/src/test/resources/org/prebid/server/it/openrtb2/connectad/test-auction-connectad-request.json b/src/test/resources/org/prebid/server/it/openrtb2/connectad/test-auction-connectad-request.json index a5abd2ecf40..00efb79c5a1 100644 --- a/src/test/resources/org/prebid/server/it/openrtb2/connectad/test-auction-connectad-request.json +++ b/src/test/resources/org/prebid/server/it/openrtb2/connectad/test-auction-connectad-request.json @@ -10,8 +10,8 @@ "tagid": "2eb6bd58-865c-47ce-af7f-a918108c3fd2", "ext": { "connectad": { - "networkId": 12, - "siteId": 15, + "networkId": "12", + "siteId": "15", "bidfloor": 14.7 } } diff --git a/src/test/resources/org/prebid/server/it/openrtb2/connectad/test-connectad-bid-request.json b/src/test/resources/org/prebid/server/it/openrtb2/connectad/test-connectad-bid-request.json index 7058b025b51..c511c5b8e65 100644 --- a/src/test/resources/org/prebid/server/it/openrtb2/connectad/test-connectad-bid-request.json +++ b/src/test/resources/org/prebid/server/it/openrtb2/connectad/test-connectad-bid-request.json @@ -15,8 +15,8 @@ "ext": { "tid": "${json-unit.any-string}", "bidder": { - "networkId": 12, - "siteId": 15, + "networkId": "12", + "siteId": "15", "bidfloor": 14.7 } } diff --git a/src/test/resources/org/prebid/server/it/openrtb2/smartx/test-smartx-bid-request.json b/src/test/resources/org/prebid/server/it/openrtb2/smartx/test-smartx-bid-request.json index d45132bc712..2374f8df992 100644 --- a/src/test/resources/org/prebid/server/it/openrtb2/smartx/test-smartx-bid-request.json +++ b/src/test/resources/org/prebid/server/it/openrtb2/smartx/test-smartx-bid-request.json @@ -40,10 +40,8 @@ "cur": [ "USD" ], - "regs": { - "ext": { - "gdpr": 0 - } + "regs" : { + "gdpr" : 0 }, "ext": { "prebid": {